[CMAKE]: Compile Target Options for ESP32 Platform #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
While compiling the project for the ESP32 I was getting two
-Wpedanticwarnings from ESP libraries (assert and twai). The code is compiling and working fine, but producing build warnings. The idea of this PR is to get rid of them since, as far as I understood, I can't add the compile option only for this library as the espressif CMake fork for won't allow me: sourceHow has this been tested?
The project was compiled both with the ESP_PLATFORM flag enabled and disabled to check the warnings during the build
Using the AgIsoStack-on-ESP32 repository to test the compile logs, we can see that the
-Wpedanticwarnings were gone.