fix: should return out malformed svg in display result

Open-Attestation · Apr 22, 2024 · 7729e0e · 7729e0e
1 parent 3a851f0
commit 7729e0e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/components/renderer/SvgRenderer.test.tsx b/src/components/renderer/SvgRenderer.test.tsx
@@ -158,13 +158,12 @@ describe("svgRenderer component", () => {
 
     fireEvent.error(getByAltText("Svg image of the verified document"));
 
-    const defaultTemplate = await findByTestId("default-template", undefined, {
-      timeout: 5000,
-    });
+    const defaultTemplate = await findByTestId("default-template");
     expect(defaultTemplate.textContent).toContain("The resolved SVG is malformedThe resolved SVG is malformed");
     expect(queryByTestId("Svg image of the verified document")).not.toBeInTheDocument();
     expect(mockHandleResult).toHaveBeenCalledWith({
       status: "INVALID_SVG_ERROR",
+      svg: "",
     });
   });
 });

diff --git a/src/components/renderer/SvgRenderer.tsx b/src/components/renderer/SvgRenderer.tsx
@@ -49,6 +49,7 @@ export type DisplayResult =
     }
   | {
       status: "INVALID_SVG_ERROR";
+      svg: string;
     };
 
 // this immediate loading state does not need to be exposed
@@ -217,6 +218,7 @@ const SvgRenderer = React.forwardRef<HTMLImageElement, SvgRendererProps>(
             onError={() => {
               handleResult({
                 status: "INVALID_SVG_ERROR",
+                svg: toDisplay.svg,
               });
             }}
           />