Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ws security advisory from ethers v5 #6

Merged
merged 2 commits into from
Jul 23, 2024
Merged

fix: ws security advisory from ethers v5 #6

merged 2 commits into from
Jul 23, 2024

Conversation

phanshiyu
Copy link

Summary

What is the background of this pull request?
use ether v5 submodules to resolve GHSA-3h5v-q93c-6h6q

Changes

  • What are the changes made in this pull request?
  • Change this and that, etc...
  1. Use only sub modules we need from ethers v5, which does not have the ws dependency that is linked to the above mentioned advisory.

Issues

What are the related issues or stories?

@phanshiyu phanshiyu changed the title chore: use v5 ethers submodules completely fix: ws security advisory from ethers v5 Jul 23, 2024
HJunyuan
HJunyuan approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@HJunyuan HJunyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@phanshiyu phanshiyu merged commit c4b2be6 into master Jul 23, 2024
1 check passed
@phanshiyu phanshiyu deleted the chore/use-ethers-v5-sub-modules branch July 23, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJunyuan HJunyuan HJunyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phanshiyu @HJunyuan