Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test ci reviewer (ignore this) #157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: test ci reviewer (ignore this) #157

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5d44a6
chore: review common mistakes
superical Jan 18, 2023
09ffa9a
Update tasks/deploy-token.ts
superical Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tasks/deploy-token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@ task(TASK_DEPLOY_TOKEN)
.addOptionalParam("factory", "Address of Title Escrow factory (Optional)")
.setAction(async ({ name, symbol, verify, factory, standalone }, hre) => {
const { ethers, network } = hre;
const { contractAddress } = constants;
const {contractAddress} = constants;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace contractAddress with ·contractAddress·

Suggested change
const {contractAddress} = constants;
const { contractAddress } = constants;


let testUselessVar;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'testUselessVar' is defined but never used.


var oldSchoolCoolVar = "cool";
superical marked this conversation as resolved.
Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'oldSchoolCoolVar' is assigned a value but never used.


try {
const [deployer] = await ethers.getSigners();
const deployerAddress = await deployer.getAddress();
Expand Down Expand Up @@ -57,7 +62,7 @@ task(TASK_DEPLOY_TOKEN)
const initParam = encodeInitParams({
name,
symbol,
deployer: deployerAddress,
deployer: deployerAddress
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,

Suggested change
deployer: deployerAddress
deployer: deployerAddress,

});
const tx = await deployerContract.deploy(implAddress, initParam);
console.log(`[Transaction] Pending ${tx.hash}`);
Expand All @@ -72,7 +77,7 @@ task(TASK_DEPLOY_TOKEN)
const token = await deployContract<TradeTrustToken>({
params: [name, symbol, factoryAddress],
contractName,
hre,
hre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,

Suggested change
hre
hre,

});
registryAddress = token.address;
}
Expand All @@ -87,7 +92,7 @@ task(TASK_DEPLOY_TOKEN)
address: registryAddress,
constructorArgsParams: [name, symbol, factoryAddress],
contract: "contracts/TradeTrustToken.sol:TradeTrustToken",
hre,
hre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,

Suggested change
hre
hre,

});
} else {
console.log("[Status] Skipped verification, already verified.");
Expand Down