154-s1orbitselection #158
Merged
154-s1orbitselection #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
HansVRP
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Hi Kristof, some comments to further improve the resilience.
Let's discuss if they are indeed required.
I would reconsider the current unit test, as its partly an integration/system test since it connects to the current back-end.
I can help to convert it to a unit-test if needed
GriffinBabe
approved these changes
Sep 11, 2024
|
@HansVRP Changes implemented, can you approve the PR? |
HansVRP
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catalogue check now also considers max temporal gap, and logs the reason for a decision being taken.