Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable black github actions workflow #22

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Enable black github actions workflow #22

merged 2 commits into from
Feb 5, 2024

Conversation

soxofaan
Copy link
Member

Issue #16

@soxofaan
Copy link
Member Author

@GriffinBabe under #16 I already merged #21 to have a minimal lint action active in github actions

But this PR#22 is quite a large code style fixup, which could easily conflict with ongoing work by you, so I'm not going to merge this blindly

@soxofaan soxofaan force-pushed the issue16-lint-black branch 4 times, most recently from fea4577 to f39960d Compare January 24, 2024 12:59
@soxofaan soxofaan force-pushed the issue16-lint-black branch 3 times, most recently from 53675b9 to 45ad51c Compare February 1, 2024 12:00
@soxofaan soxofaan marked this pull request as draft February 1, 2024 13:14
@soxofaan
Copy link
Member Author

soxofaan commented Feb 1, 2024

changed this PR to a draft PR, because it is probably too conflict-risky

alternative:

  • first introduce "darker" as github action linter, to enforce that at least edited/new code is black compatible, this approach should not cause sudden conflicts on open branhces

@soxofaan
Copy link
Member Author

soxofaan commented Feb 1, 2024

started with PR #39 to first start with "darker" instead of "black"

@soxofaan
Copy link
Member Author

soxofaan commented Feb 2, 2024

as discussed: we first want to get #38 merged before continuing working on this #22 or #39

@GriffinBabe GriffinBabe marked this pull request as ready for review February 5, 2024 08:47
@soxofaan soxofaan merged commit 71969bf into main Feb 5, 2024
2 checks passed
@soxofaan soxofaan deleted the issue16-lint-black branch February 5, 2024 11:01
@soxofaan
Copy link
Member Author

soxofaan commented Feb 5, 2024

as discussed, merged this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants