Curve cleanup #73
Merged
Curve cleanup #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2023 11:43
…unctions in the future, predict_curves function will now also be replaced in the same way as fit_curves
… function generation
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 91.39% 92.09% +0.69%
==========================================
Files 6 6
Lines 686 683 -3
==========================================
+ Hits 627 629 +2
+ Misses 59 54 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| "data": [ | ||
| 3, | ||
| 2 | ||
| ], | ||
| "index": 2 |
There was a problem hiding this comment.
isn't index: 2 out of range for data = [3,2]? This probably doesn't matter to test the functionality :)
There was a problem hiding this comment.
Yea I forgot I changed that and never changed it back, it would matter if the compiled function from fit_curve would ever be executed, which it's not. We don't check for potential runtime errors when compiling, that's out of scope.
The actual testing of the functions execution happens in the new test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup: Cleaned up code and made it easier to add various functions in the future
Fix: Array_element didn't support actual arrays
Added: test for function generation
Fix: Generate function wasn't being used for predict_curve