Skip to content

Commit

Permalink
Issue #604/#644 add some todo note for furtherdevelopment ideas
Browse files Browse the repository at this point in the history
  • Loading branch information
soxofaan committed Oct 14, 2024
1 parent 130db87 commit 2667733
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions openeo/extra/job_management.py
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,9 @@ class UDPJobFactory:
.. versionadded:: 0.33.0
"""

# TODO: find a better class name (e.g. eliminate over-specificity of "UDP",
# or avoid "factory" as technical mumbo-jumbo)?

def __init__(
self,
*,
Expand Down Expand Up @@ -1048,6 +1051,8 @@ def start_job(self, row: pd.Series, connection: Connection, **_) -> BatchJob:
:param row: The row in the pandas dataframe that stores the jobs state and other tracked data.
:param connection: The connection to the backend.
"""
# TODO: refactor out some methods, for better reuse and decoupling:
# `get_arguments()` (to build the arguments dictionary), `get_cube()` (to create the cube),

process_definition = self._get_process_definition(connection=connection)
process_id = process_definition.id
Expand Down

0 comments on commit 2667733

Please sign in to comment.