Skip to content

Commit

Permalink
fix some trivial bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
thomaslepoix committed Nov 19, 2024
1 parent 197d85b commit 99172b8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 2 additions & 0 deletions src/domain/conflicts/conflict.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ namespace domain {
Conflict::Conflict(Kind const kind)
: IMeshLineOrigin()
, kind(kind)
, is_solved(false)
, solution(nullptr)
{}

} // namespace domain
3 changes: 2 additions & 1 deletion test/unit/domain/geometrics/test_segment.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ SCENARIO("std::optional<Axis> transpose(Plane const plane, Segment::Axis const a
std::optional<Axis> c(transpose(XY, Segment::Axis::POINT));
REQUIRE_FALSE(a.has_value());
REQUIRE_FALSE(b.has_value());
REQUIRE_FALSE(c.has_value()); }
REQUIRE_FALSE(c.has_value());
}
}
}
}
4 changes: 2 additions & 2 deletions test/unit/utils/test_vector_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ SCENARIO("template<typename T, typename P> bool contains_that(std::vector<T> con
std::string b("b");
REQUIRE(contains_that(a,
[&b](std::unique_ptr<std::string> const& str) {
return str->c_str() == b.c_str();
return *str == b;
}));
}
}
Expand All @@ -120,7 +120,7 @@ SCENARIO("template<typename T, typename P> bool contains_that(std::vector<T> con
std::string b("ccc");
REQUIRE_FALSE(contains_that(a,
[&b](std::unique_ptr<std::string> const& str) {
return str->c_str() == b.c_str();
return *str == b;
}));
}
}
Expand Down

0 comments on commit 99172b8

Please sign in to comment.