Remove unneeded vault_url from request resource

OpenAxon · Jul 12, 2024 · efecdfb · efecdfb
1 parent f17a5f8
commit efecdfb
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 13 deletions.
diff --git a/README.md b/README.md
@@ -36,7 +36,6 @@ resource "azurekvca_create" "test" {
 
 # Optionally mangle the CSR to add values not supported by Azure (URI SAN for example)
 resource "azurekvca_request" "test" {
-  vault_url  = azurekvca_create.test.vault_url
   csr_pem_in = azurekvca_create.test.csr_pem
 
   names = {

diff --git a/docs/index.md b/docs/index.md
@@ -42,7 +42,6 @@ resource "azurekvca_create" "test" {
 
 # Optionally mangle the CSR to add values not supported by Azure (URI SAN for example)
 resource "azurekvca_request" "test" {
-  vault_url  = azurekvca_create.test.vault_url
   csr_pem_in = azurekvca_create.test.csr_pem
 
   names = {

diff --git a/docs/resources/request.md b/docs/resources/request.md
@@ -19,7 +19,6 @@ Mangle a CSR to add fields that aren't supported by Azure (URI SANs)
 
 - `csr_pem_in` (String) Input CSR in PEM format
 - `names` (Attributes) SAN values to set (see [below for nested schema](#nestedatt--names))
-- `vault_url` (String) URL of Azure Key Vault
 
 ### Read-Only
 

diff --git a/internal/provider/request_resource.go b/internal/provider/request_resource.go
@@ -43,7 +43,6 @@ type requestResourceModel struct {
 	CSRPEMIn  types.String `tfsdk:"csr_pem_in"`
 	CSRPEMOut types.String `tfsdk:"csr_pem_out"`
 	Names     requestNames `tfsdk:"names"`
-	VaultURL  types.String `tfsdk:"vault_url"`
 }
 
 // Metadata returns the resource type name.
@@ -96,13 +95,6 @@ func (r *requestResource) Schema(_ context.Context, _ resource.SchemaRequest, re
 					objectplanmodifier.RequiresReplace(),
 				},
 			},
-			"vault_url": schema.StringAttribute{
-				MarkdownDescription: "URL of Azure Key Vault",
-				Required:            true,
-				PlanModifiers: []planmodifier.String{
-					stringplanmodifier.RequiresReplace(),
-				},
-			},
 		},
 	}
 }
@@ -179,7 +171,7 @@ func (r *requestResource) Create(ctx context.Context, req resource.CreateRequest
 		}
 	}
 
-	signer, err := NewAzureKVSigner(ctx, *r.azureCred, plan.VaultURL.ValueString(), "", "", parsedCSR.PublicKey)
+	signer, err := NewAzureKVSigner(ctx, *r.azureCred, "", "", "", parsedCSR.PublicKey)
 	if err != nil {
 		resp.Diagnostics.AddError(
 			"Error creating signer",

diff --git a/templates/index.md.tmpl b/templates/index.md.tmpl
@@ -42,7 +42,6 @@ resource "azurekvca_create" "test" {
 
 # Optionally mangle the CSR to add values not supported by Azure (URI SAN for example)
 resource "azurekvca_request" "test" {
-  vault_url  = azurekvca_create.test.vault_url
   csr_pem_in = azurekvca_create.test.csr_pem
 
   names = {