Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SIDER #438

Merged
merged 13 commits into from
Nov 1, 2023
Merged

add SIDER #438

merged 13 commits into from
Nov 1, 2023

Conversation

AdrianM0
Copy link
Contributor

@AdrianM0 AdrianM0 commented Oct 18, 2023

One more dataset from moleculeNet. 🥳

names:
- noun: metabolism and nutrition disorders
- id: product_issues
description: product issues
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean? what is an example of a product issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdrianM0 do you know what product issues is supposed to mean? Does this noun fit the column name?

type: boolean
names:
- noun: gastrointestinal disorders
- id: social_circumstances
Copy link
Collaborator

@kjappelbaum kjappelbaum Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a disorder?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or is this some kind of disorder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjappelbaum I can also remove these two?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also an option if you cannot figure out what those are about

@kjappelbaum kjappelbaum self-requested a review October 22, 2023 19:10
Comment on lines 24 to 33
- id: investigations
description: eye disorders
type: boolean
names:
- noun: eye disorders
- id: musculoskeletal_and_connective_tissue_disorders
description: investigations
type: boolean
names:
- noun: investigations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't there a mismatch between your column names and the names?
They seem one off.

Generally, it is probably better if we can manage to get multiple names to increase the diversity of the training data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this now, added one noun to each

Comment on lines 27 to 32
- id: investigations
description: investigations
type: boolean
names:
- noun: investigations
- noun: medical investigations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to sample this one/do you know what this one means?

Comment on lines 153 to 158
- id: injury_poisoning_and_procedural_complications
description: injury, poisoning and procedural complications
type: boolean
names:
- noun: injury, poisoning and procedural complications
- noun: injuries, poisonings, and complications from procedures
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"complications from procedures" -> this does not sound like a drug side effect to me ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refers to post-surgery complications likely

@kjappelbaum
Copy link
Collaborator

Thanks for all the updates, and sorry for being so picky!

@AdrianM0
Copy link
Contributor Author

@kjappelbaum this can be closed I think

@kjappelbaum
Copy link
Collaborator

kjappelbaum commented Oct 27, 2023

With closed, do you mean merged?

Comment on lines 147 to 152
- id: injury_poisoning_and_procedural_complications
description: injury, poisoning and procedural complications
type: boolean
names:
- noun: injury, poisoning and procedural complications
- noun: injuries and poisonings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm still not sure about this. You put in SMILES and then predict something about "procedural complications" which sounds more like surgery

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdrianM0, what are your thoughts on this one?

@kjappelbaum
Copy link
Collaborator

can you, as discussed, remove the columns we are uncertain about? (https://discord.com/channels/@me/1138533229381550181/1168595210876485673)

Copy link
Collaborator

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the patience throughout all those updates!

@kjappelbaum kjappelbaum merged commit 4f036a1 into OpenBioML:main Nov 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants