-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SIDER #438
add SIDER #438
Conversation
data/tabular/SIDER/meta.yaml
Outdated
names: | ||
- noun: metabolism and nutrition disorders | ||
- id: product_issues | ||
description: product issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean? what is an example of a product issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdrianM0 do you know what product issues is supposed to mean? Does this noun fit the column name?
data/tabular/SIDER/meta.yaml
Outdated
type: boolean | ||
names: | ||
- noun: gastrointestinal disorders | ||
- id: social_circumstances |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a disorder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or is this some kind of disorder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kjappelbaum I can also remove these two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also an option if you cannot figure out what those are about
data/tabular/SIDER/meta.yaml
Outdated
- id: investigations | ||
description: eye disorders | ||
type: boolean | ||
names: | ||
- noun: eye disorders | ||
- id: musculoskeletal_and_connective_tissue_disorders | ||
description: investigations | ||
type: boolean | ||
names: | ||
- noun: investigations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't there a mismatch between your column names and the names
?
They seem one off.
Generally, it is probably better if we can manage to get multiple names to increase the diversity of the training data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this now, added one noun to each
data/tabular/SIDER/meta.yaml
Outdated
- id: investigations | ||
description: investigations | ||
type: boolean | ||
names: | ||
- noun: investigations | ||
- noun: medical investigations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to sample this one/do you know what this one means?
data/tabular/SIDER/meta.yaml
Outdated
- id: injury_poisoning_and_procedural_complications | ||
description: injury, poisoning and procedural complications | ||
type: boolean | ||
names: | ||
- noun: injury, poisoning and procedural complications | ||
- noun: injuries, poisonings, and complications from procedures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"complications from procedures" -> this does not sound like a drug side effect to me ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refers to post-surgery complications likely
Thanks for all the updates, and sorry for being so picky! |
@kjappelbaum this can be closed I think |
With closed, do you mean merged? |
data/tabular/SIDER/meta.yaml
Outdated
- id: injury_poisoning_and_procedural_complications | ||
description: injury, poisoning and procedural complications | ||
type: boolean | ||
names: | ||
- noun: injury, poisoning and procedural complications | ||
- noun: injuries and poisonings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm still not sure about this. You put in SMILES and then predict something about "procedural complications" which sounds more like surgery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdrianM0, what are your thoughts on this one?
can you, as discussed, remove the columns we are uncertain about? (https://discord.com/channels/@me/1138533229381550181/1168595210876485673) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the patience throughout all those updates!
One more dataset from moleculeNet. 🥳