Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Permanent Distance Restraints #110

Merged
merged 7 commits into from
Oct 7, 2023

Conversation

fjclark
Copy link
Collaborator

@fjclark fjclark commented Oct 2, 2023

Is this pull request to fix a bug, or to introduce new functionality?

This PR adds support for one or more "permanent" distance restraints. These are distance restraints that are always applied, and are never scaled by λ. This allows the release of all other distance restraints to a single harmonic or flat-bottomed restraint. When the ligand is fully decoupled, the free energy of release of the single remaining restraint can be computed without simulation. This provides more options for using multiple distance restraints in ABFE calculations.

I will create a parallel PR to BioSimSpace with functionality for setting up and running ABFE calculations in this way.

If this introduces new functionality...

Changes proposed in this pull request:

  • Introduce "permanent distance restraints" which are never scaled by λ.
  • Add new 'always dummy' group for atoms which begin and end as dummies
  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): y
  • I confirm that I have added a test for any new functionality in this pull request: n
  • I confirm that I have added documentation (e.g. a new tutorial page or detailed guide) for any new functionality in this pull request: n
  • I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): y
  • I confirm that I have permission to release this code under the GPL3 license: y

I haven't yet added new tests as I was unsure how best to do this. Ideally, I would add some tests similar to this. Would a test like this be too slow? What would you recommend?

Suggested reviewers:

@chryswoods, @lohedges

Any additional context of information?

I'm currently testing SOMD ABFE calculations with Boresch restraints against multiple distance restraints as shown here. Both methods produce results which are statistically indistinguishable with the TYK2 system tested:

image

Thanks very much.

fjclark and others added 6 commits August 7, 2023 11:05
This allows the use of "permanent" distance restraints which
are always at full strength, even in "turn on receptor-ligand
restraints mode". This allows multiple distance restraint protocols
which involve turning off some distance restraints without affecting
others.
@fjclark fjclark temporarily deployed to sire-build October 2, 2023 16:23 — with GitHub Actions Inactive
@fjclark fjclark temporarily deployed to sire-build October 2, 2023 16:23 — with GitHub Actions Inactive
@fjclark fjclark temporarily deployed to sire-build October 2, 2023 16:23 — with GitHub Actions Inactive
@fjclark fjclark temporarily deployed to sire-build October 2, 2023 16:23 — with GitHub Actions Inactive
Copy link
Contributor

@chryswoods chryswoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chryswoods chryswoods merged commit 1d1c97f into OpenBioSim:devel Oct 7, 2023
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants