Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature choices #118

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Feature choices #118

merged 4 commits into from
Oct 30, 2023

Conversation

chryswoods
Copy link
Contributor

From the changelog

Added a new sire.options module that contains new sire.options.Option objects to represent configurable options. These include documentation, and make it easier to validate and expose possible values of configurable options. The API docs for sire.options.Option shows how to create your own Option type. The unit test in tests/options/test_options.py show how to use the options. This is integrated into the sire/OpenMM layer.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have added a test for any new functionality in this pull request: [y]
  • I confirm that I have added documentation (e.g. a new tutorial page or detailed guide) for any new functionality in this pull request: [y (API docs)]
  • I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

Suggested reviewers

@lohedges, @mb2055

Any additional context of information?

I hope this makes it easier to get hold of all the possible values for the somd2 API, and get the associated help text.

@chryswoods chryswoods temporarily deployed to sire-build October 24, 2023 18:26 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build October 24, 2023 18:26 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build October 24, 2023 18:27 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build October 24, 2023 18:27 — with GitHub Actions Inactive
@chryswoods
Copy link
Contributor Author

MacOS X86 failure is a precision error against an energy calculation

>       assert omm.get_energy().value() == pytest.approx(nrg0)
E       assert 274.24741186681086 == 274.2471225087155 ± 2.7e-04
E         comparison failed
E         Obtained: 274.24741186681086
E         Expected: 274.2471225087155 ± 2.7e-04

I've not seen this before, and don't see this locally. I'll double-check things but suspect it is just something spurious.

@chryswoods chryswoods temporarily deployed to sire-build October 25, 2023 07:09 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build October 25, 2023 07:09 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build October 25, 2023 07:09 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build October 25, 2023 07:09 — with GitHub Actions Inactive
@chryswoods
Copy link
Contributor Author

It's reproducible. I don't see this on MacOS ARM64 with CPU, and hadn't seen this before. It's only a 1e-5 difference, so within rounding error for the CPU platform (I'd guess).

@chryswoods chryswoods merged commit 2847ce8 into devel Oct 30, 2023
@chryswoods chryswoods deleted the feature_choices branch October 30, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant