Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix from PR #123 #124

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Backport fix from PR #123 #124

merged 2 commits into from
Nov 9, 2023

Conversation

lohedges
Copy link
Contributor

@lohedges lohedges commented Nov 9, 2023

This PR backports the fix from #123 into main.

  • I confirm that I have merged the latest version of main into this branch before issuing this pull request (e.g. by running git pull origin main): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@lohedges lohedges added bug Something isn't working exscientia Related to work with Exscientia labels Nov 9, 2023
@lohedges
Copy link
Contributor Author

lohedges commented Nov 9, 2023

Not sure if I also need to add the entry to the CHANGELOG? This is done on devel under the 2023.5.0 section. Perhaps you look at fixes from that section when creating a patch release and add them to the respective 2023.4.X section.

@chryswoods
Copy link
Contributor

Could you create a 2023.4.2 section in the changelog and add it to there? I then compare the devel changelog to the one in main when I do the next major release, and will remove anything that is duplicated from the previous patch release.

@lohedges
Copy link
Contributor Author

lohedges commented Nov 9, 2023

Yes, no problem. I just wasn't completely sure of the system since you could end up adding a section for a patch release that never happens. I guess it all gets sorted out at release time anyway, so it's good to have something to cross reference.

@lohedges
Copy link
Contributor Author

lohedges commented Nov 9, 2023

Done 👍

@lohedges lohedges merged commit 8cf9c15 into main Nov 9, 2023
@lohedges lohedges deleted the backport_123 branch November 9, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exscientia Related to work with Exscientia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants