Fix issue #130

[lohedges]

This PR closes #130 by allowing the perturbable_constraint dynamics option to contain hyphens.

• I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
• I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): [y]
• I confirm that I have permission to release this code under the GPL3 license: [y]

Suggested reviewers:

@chryswoods

[chryswoods]

Looks good. I think this highlights that the way I did this for constraint was error prone. I think it should be that there is a replace("-", "_") after the simplify, so that we can match any mix of hyphens or underscores.

[lohedges]

You do sanitize in the Python layer, i.e. everything gets converted to underscores. Are there situations where the C++ is being called directly?

[chryswoods]

Not currently, but it is better to be safe than sorry. There would be an edge case where someone sets this as a map parameter that bypasses the sanitation.

[chryswoods]

All good