Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 137 #138

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Fix 137 #138

merged 3 commits into from
Dec 12, 2023

Conversation

chryswoods
Copy link
Contributor

This pull request fixes issue #137

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

Suggested reviewers

@lohedges

Any additional context of information?

There's a bit of formatting change because of my move to Ruff

@chryswoods
Fixed the bug - the .commit() functions now return the right type.
631d01e 
I've added tests for `.minimisation()` and `.dynamics()` to prevent
regressions
@chryswoods
Added a changelog entry
82576b4
@chryswoods chryswoods linked an issue Dec 12, 2023 that may be closed by this pull request
minimisation().commit() and dynamics().commit() return the wrong type #137
Closed
@chryswoods chryswoods merged commit d7a2c5d into devel Dec 12, 2023
@chryswoods chryswoods deleted the fix-137 branch December 12, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minimisation().commit() and dynamics().commit() return the wrong type
1 participant
@chryswoods