Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_147 #158

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix_147 #158

merged 2 commits into from
Feb 9, 2024

Conversation

chryswoods
Copy link
Contributor

If this is to fix a bug...

This pull request fixes issue #147

Adds in support for Python 3.12. This was a very minor (1-line) fix.
This is built from feature_force_lever, so accepting this will accept that.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

Suggested reviewers:

@lohedges, @mb2055

lohedges
lohedges previously approved these changes Feb 9, 2024
Copy link
Contributor

@lohedges lohedges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. The BioSimSpace and SOMD2 tests pass without issue.

@chryswoods
Copy link
Contributor Author

I'll approve your pull request and will then add Python 3.10 Mac to the devel build, and will then accept the PR to build all new devel packages.

@chryswoods chryswoods dismissed lohedges’s stale review February 9, 2024 18:13

The merge-base changed after approval.

@chryswoods chryswoods merged commit cd2fbc6 into devel Feb 9, 2024
0 of 5 checks passed
@chryswoods chryswoods deleted the feature_python_312 branch February 10, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sire fails to compile with python 3.12
2 participants