Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps]: loose opentelemetry-xxx required versions (#818) #846

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

flavienSindou
Copy link
Contributor

Proposed changes

  • Loose opentelemetry-api/sdk required versions in dependencies

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Opentelemetry python packages available versions are.

$ python -m pip index versions opentelemetry-sdk
Available versions: 1.30.0, 1.29.0, 1.28.2, 1.28.1, 1.28.0, 1.27.0, 1.26.0, 1.25.0, 1.24.0, 1.23.0, 1.22.0, 1.21.0, 1.20.0, 1.19.0, 1.18.0, 1.17.0, 1.16.0, 1.15.0, 1.14.0, 1.13.0, 1.12.0, 1.11.1, 1.11.0, 1.10.0, 1.9.1, 1.9.0, 1.8.0, 1.7.1, 1.7.0, 1.6.2, 1.6.1, 1.6.0, 1.5.0, 1.4.1, 1.4.0, 1.3.0, 1.2.0, 1.1.0, 1.0.0

We are currently using 1.22.0, released in December 2023 ! open-telemetry/opentelemetry-python@e6602ff

Using the tox tool, and based on successful package installation with pip and tests performed with pytest, we can conclude that we are, at a minimum, compatible with opentelemetry-sdk/api versions [1.22.0 to 1.30.0] when using Python [3.8 to 3.12].

See Notion page for details : https://www.notion.so/filigran/Loose-OpenTelemetry-required-versions-in-opencti-python-client-19d8fce17f2a80128378d53a1a071895?pvs=4

@flavienSindou flavienSindou added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team labels Feb 17, 2025
@flavienSindou flavienSindou self-assigned this Feb 17, 2025
@flavienSindou flavienSindou linked an issue Feb 17, 2025 that may be closed by this pull request
@aHenryJard aHenryJard changed the title [deps]: loose opentelemetry-xxx required versions [deps]: loose opentelemetry-xxx required versions (#818) Feb 18, 2025
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@flavienSindou flavienSindou merged commit 1e227fd into master Feb 19, 2025
6 checks passed
@flavienSindou flavienSindou deleted the bug/818-opentelemetry-requirements-too-strict branch February 19, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry requirements too strict
2 participants