Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISP] handle PAP markings, use TLP:CLEAR instead of TLP:WHITE #3354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MISP] handle PAP markings, use TLP:CLEAR instead of TLP:WHITE #3354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 69 additions & 9 deletions external-import/misp/src/misp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,51 @@
}
FILETYPES = ["file-name", "file-md5", "file-sha1", "file-sha256"]

marking_tlp_clear = stix2.MarkingDefinition(
id=MarkingDefinition.generate_id("TLP", "TLP:CLEAR"),
definition_type="statement",
definition={"statement": "custom"},
allow_custom=True,
x_opencti_definition_type="TLP",
x_opencti_definition="TLP:CLEAR",
)

marking_pap_clear = stix2.MarkingDefinition(
id=MarkingDefinition.generate_id("PAP", "PAP:CLEAR"),
definition_type="statement",
definition={"statement": "custom"},
allow_custom=True,
x_opencti_definition_type="PAP",
x_opencti_definition="PAP:CLEAR",
)

marking_pap_green = stix2.MarkingDefinition(
id=MarkingDefinition.generate_id("PAP", "PAP:GREEN"),
definition_type="statement",
definition={"statement": "custom"},
allow_custom=True,
x_opencti_definition_type="PAP",
x_opencti_definition="PAP:GREEN",
)

marking_pap_amber = stix2.MarkingDefinition(
id=MarkingDefinition.generate_id("PAP", "PAP:AMBER"),
definition_type="statement",
definition={"statement": "custom"},
allow_custom=True,
x_opencti_definition_type="PAP",
x_opencti_definition="PAP:AMBER",
)

marking_pap_red = stix2.MarkingDefinition(
id=MarkingDefinition.generate_id("PAP", "PAP:RED"),
definition_type="statement",
definition={"statement": "custom"},
allow_custom=True,
x_opencti_definition_type="PAP",
x_opencti_definition="PAP:RED",
)


def is_uuid(val):
try:
Expand Down Expand Up @@ -612,7 +657,7 @@ def process_events(self, work_id, events):
if "Tag" in event["Event"]:
event_markings = self.resolve_markings(event["Event"]["Tag"])
else:
event_markings = [stix2.TLP_WHITE]
event_markings = [marking_tlp_clear]
# Elements
event_elements = self.prepare_elements(
event["Event"].get("Galaxy", []),
Expand Down Expand Up @@ -2353,9 +2398,9 @@ def resolve_markings(self, tags, with_default=True):
)
markings.append(marking)
if tag_name_lower == "tlp:clear":
markings.append(stix2.TLP_WHITE)
markings.append(marking_tlp_clear)
if tag_name_lower == "tlp:white":
markings.append(stix2.TLP_WHITE)
markings.append(marking_tlp_clear)
if tag_name_lower == "tlp:green":
markings.append(stix2.TLP_GREEN)
if tag_name_lower == "tlp:amber":
Expand All @@ -2372,8 +2417,17 @@ def resolve_markings(self, tags, with_default=True):
markings.append(marking)
if tag_name_lower == "tlp:red":
markings.append(stix2.TLP_RED)
# handle PAP markings
if tag_name_lower == "pap:clear":
markings.append(marking_pap_clear)
if tag_name_lower == "pap:green":
markings.append(marking_pap_green)
if tag_name_lower == "pap:amber":
markings.append(marking_pap_amber)
if tag_name_lower == "pap:red":
markings.append(marking_pap_red)
if len(markings) == 0 and with_default:
markings.append(stix2.TLP_WHITE)
markings.append(marking_tlp_clear)
return markings

def resolve_tags(self, tags):
Expand All @@ -2384,6 +2438,7 @@ def resolve_tags(self, tags):

for tag in tags:
self.helper.log_info(f"found tag: {tag}")
tag_name_lower = tag["name"].lower()
# we take the tag as-is if it starts by a prefix stored in the keep_original_tags_as_label configuration
if any(
map(
Expand All @@ -2395,11 +2450,16 @@ def resolve_tags(self, tags):
opencti_tags.append(tag["name"])

elif (
tag["name"] != "tlp:white"
and tag["name"] != "tlp:green"
and tag["name"] != "tlp:amber"
and tag["name"] != "tlp:amber+strict"
and tag["name"] != "tlp:red"
tag_name_lower != "tlp:white"
and tag_name_lower != "tlp:clear"
and tag_name_lower != "tlp:green"
and tag_name_lower != "tlp:amber"
and tag_name_lower != "tlp:amber+strict"
and tag_name_lower != "tlp:red"
and tag_name_lower != "pap:clear"
and tag_name_lower != "pap:green"
and tag_name_lower != "pap:amber"
and tag_name_lower != "pap:red"
and not tag["name"].startswith("misp-galaxy:threat-actor")
and not tag["name"].startswith("misp-galaxy:mitre-threat-actor")
and not tag["name"].startswith("misp-galaxy:microsoft-activity-group")
Expand Down