Fixed "ServiceProvider given, array expected during unsollicited sing…

…le sign-on" #149 #149
OpenConext · Aug 4, 2015 · 122535b · 122535b
1 parent 4f6136c
commit 122535b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/library/EngineBlock/Corto/Module/Service/SingleSignOn.php b/library/EngineBlock/Corto/Module/Service/SingleSignOn.php
@@ -2,6 +2,7 @@
 
 use \OpenConext\Component\EngineBlockFixtures\IdFrame;
 use OpenConext\Component\EngineBlockMetadata\Entity\IdentityProvider;
+use OpenConext\Component\EngineBlockMetadata\Entity\ServiceProvider;
 
 class EngineBlock_Corto_Module_Service_SingleSignOn extends EngineBlock_Corto_Module_Service_Abstract
 {
@@ -133,12 +134,12 @@ protected function _getRequest($serviceName)
 
     /**
      * @param EngineBlock_Saml2_AuthnRequestAnnotationDecorator $request
-     * @param array $remoteEntity
+     * @param ServiceProvider $remoteEntity
      * @return bool
      */
     protected function _verifyAcsLocation(
         EngineBlock_Saml2_AuthnRequestAnnotationDecorator $request,
-        array $remoteEntity
+        ServiceProvider $remoteEntity
     ) {
         /** @var SAML2_AuthnRequest $request */
         // show error when acl is given without binding or vice versa

diff --git a/library/EngineBlock/Corto/ProxyServer.php b/library/EngineBlock/Corto/ProxyServer.php
@@ -587,8 +587,9 @@ public function getDefaultAssertionConsumer(ServiceProvider $serviceProvider)
      * Returns a custom ACS location from request or false when
      * none is specified
      *
-     * @param array $request
-     * @param array $serviceProvider
+     * @param EngineBlock_Saml2_AuthnRequestAnnotationDecorator $request
+     * @param ServiceProvider $serviceProvider
+     * @return null|\OpenConext\Component\EngineBlockMetadata\IndexedService
      */
     public function getCustomAssertionConsumer(
         EngineBlock_Saml2_AuthnRequestAnnotationDecorator $request,