Optimize imports

config/packages/smoketest/web_profiler.yaml

@@ -1,6 +1,6 @@
 web_profiler:
-    toolbar: false
+    toolbar: true
     intercept_redirects: false
 
 framework:
-    profiler: { collect: false }
+    profiler: { collect: true }

src/Surfnet/StepupRa/RaBundle/Exception/InvalidArgumentException.php

@@ -18,7 +18,7 @@
 
 namespace Surfnet\StepupRa\RaBundle\Exception;
 
-use \InvalidArgumentException as BaseInvalidArgumentException;
+use InvalidArgumentException as BaseInvalidArgumentException;
 
 class InvalidArgumentException extends BaseInvalidArgumentException
 {

src/Surfnet/StepupRa/RaBundle/Exception/UserNotRaException.php

@@ -19,7 +19,6 @@
 namespace Surfnet\StepupRa\RaBundle\Exception;
 
 use Symfony\Component\HttpKernel\Attribute\WithHttpStatus;
-use Symfony\Component\Security\Core\Exception\AuthenticationException;
 
 /**
  * Exception for the case where a user is not granted RA privileges.

src/Surfnet/StepupRa/RaBundle/Form/Type/AmendRegistrationAuthorityInformationType.php

@@ -18,12 +18,12 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupRa\RaBundle\Command\AmendRegistrationAuthorityInformationCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\Extension\Core\Type\TextareaType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupRa\RaBundle\Command\AmendRegistrationAuthorityInformationCommand;
 
 class AmendRegistrationAuthorityInformationType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/ChangeRaLocationType.php

@@ -18,12 +18,12 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupRa\RaBundle\Command\ChangeRaLocationCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\Extension\Core\Type\TextareaType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupRa\RaBundle\Command\ChangeRaLocationCommand;
 
 class ChangeRaLocationType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/ChangeRaRoleType.php

@@ -18,13 +18,13 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupRa\RaBundle\Command\ChangeRaRoleCommand;
 use Surfnet\StepupRa\RaBundle\Form\Extension\RaRoleChoiceList;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupRa\RaBundle\Command\ChangeRaRoleCommand;
 
 class ChangeRaRoleType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/CreateRaLocationType.php

@@ -18,12 +18,12 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupRa\RaBundle\Command\CreateRaLocationCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\Extension\Core\Type\TextareaType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupRa\RaBundle\Command\CreateRaLocationCommand;
 
 class CreateRaLocationType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/RemoveRaLocationType.php

@@ -18,11 +18,11 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupRa\RaBundle\Command\RemoveRaLocationCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\HiddenType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupRa\RaBundle\Command\RemoveRaLocationCommand;
 
 class RemoveRaLocationType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/RetractRegistrationAuthorityType.php

@@ -18,11 +18,11 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupRa\RaBundle\Command\RetractRegistrationAuthorityCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupRa\RaBundle\Command\RetractRegistrationAuthorityCommand;
 
 class RetractRegistrationAuthorityType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/RevokeSecondFactorType.php

@@ -18,11 +18,11 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupRa\RaBundle\Command\RevokeSecondFactorCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\HiddenType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupRa\RaBundle\Command\RevokeSecondFactorCommand;
 
 class RevokeSecondFactorType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/SendSmsChallengeType.php

@@ -18,11 +18,11 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupBundle\Command\SendSmsChallengeCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupBundle\Command\SendSmsChallengeCommand;
 
 class SendSmsChallengeType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/StartVettingProcedureType.php

@@ -19,12 +19,12 @@
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
 use JMS\TranslationBundle\Annotation\Ignore;
+use Surfnet\StepupRa\RaBundle\Command\StartVettingProcedureCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupRa\RaBundle\Command\StartVettingProcedureCommand;
 
 class StartVettingProcedureType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/VerifyIdentityType.php

@@ -18,13 +18,13 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupRa\RaBundle\Command\VerifyIdentityCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupRa\RaBundle\Command\VerifyIdentityCommand;
 
 class VerifyIdentityType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/VerifyPhoneNumberType.php

@@ -18,12 +18,12 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupBundle\Command\VerifyPossessionOfPhoneCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupBundle\Command\VerifyPossessionOfPhoneCommand;
 
 class VerifyPhoneNumberType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Form/Type/VerifyYubikeyPublicIdType.php

@@ -18,10 +18,10 @@
 
 namespace Surfnet\StepupRa\RaBundle\Form\Type;
 
+use Surfnet\StepupRa\RaBundle\Command\VerifyYubikeyPublicIdCommand;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Surfnet\StepupRa\RaBundle\Command\VerifyYubikeyPublicIdCommand;
 
 class VerifyYubikeyPublicIdType extends AbstractType
 {

src/Surfnet/StepupRa/RaBundle/Security/Factory/SamlFactory.php

@@ -22,8 +22,8 @@
 
 use Symfony\Bundle\SecurityBundle\DependencyInjection\Security\Factory\AuthenticatorFactoryInterface;
 use Symfony\Component\Config\Definition\Builder\NodeDefinition;
-use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\ChildDefinition;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 
 class SamlFactory implements AuthenticatorFactoryInterface
 {

src/Surfnet/StepupRa/RaBundle/Service/CommandService.php

@@ -18,12 +18,12 @@
 
 namespace Surfnet\StepupRa\RaBundle\Service;
 
+use Surfnet\StepupMiddlewareClient\Service\ExecutionResult;
 use Surfnet\StepupMiddlewareClientBundle\Command\Command;
 use Surfnet\StepupMiddlewareClientBundle\Command\Metadata;
 use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\Identity;
 use Surfnet\StepupMiddlewareClientBundle\Service\CommandService as MiddlewareCommandService;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
-use Surfnet\StepupMiddlewareClient\Service\ExecutionResult;
 
 final readonly class CommandService
 {

src/Surfnet/StepupRa/RaBundle/Service/GssfService.php

@@ -19,9 +19,7 @@
 namespace Surfnet\StepupRa\RaBundle\Service;
 
 use Surfnet\StepupRa\RaBundle\Service\Gssf\VerificationResult;
-use Symfony\Component\DependencyInjection\Attribute\Autowire;
 use Symfony\Component\HttpFoundation\RequestStack;
-use Symfony\Component\HttpFoundation\Session\Attribute\AttributeBagInterface;
 
 final readonly class GssfService
 {

src/Surfnet/StepupRa/RaBundle/Service/RaService.php

@@ -19,8 +19,7 @@
 namespace Surfnet\StepupRa\RaBundle\Service;
 
 use Psr\Log\LoggerInterface;
-use Surfnet\StepupMiddlewareClientBundle\Identity\Command\AmendRegistrationAuthorityInformationCommand
-    as AmendRegistrationAuthorityInformationApiCommand;
+use Surfnet\StepupMiddlewareClientBundle\Identity\Command\AmendRegistrationAuthorityInformationCommand as AmendRegistrationAuthorityInformationApiCommand;
 use Surfnet\StepupMiddlewareClientBundle\Identity\Command\AppointRoleCommand;
 use Surfnet\StepupMiddlewareClientBundle\Identity\Command\RetractRegistrationAuthorityCommand as ApiRetractRegistrationAuthorityCommand;
 use Surfnet\StepupRa\RaBundle\Command\AmendRegistrationAuthorityInformationCommand;

src/Surfnet/StepupRa/RaBundle/Service/VettingService.php

@@ -31,8 +31,8 @@
 use Surfnet\StepupBundle\Value\SecondFactorType;
 use Surfnet\StepupBundle\Value\VettingType;
 use Surfnet\StepupMiddlewareClient\Service\ExecutionResult;
-use Surfnet\StepupMiddlewareClientBundle\Identity\Service\SecondFactorService;
 use Surfnet\StepupMiddlewareClientBundle\Identity\Command\VetSecondFactorCommand;
+use Surfnet\StepupMiddlewareClientBundle\Identity\Service\SecondFactorService;
 use Surfnet\StepupRa\RaBundle\Command\StartVettingProcedureCommand;
 use Surfnet\StepupRa\RaBundle\Command\VerifyIdentityCommand;
 use Surfnet\StepupRa\RaBundle\Command\VerifyYubikeyPublicIdCommand;

src/Surfnet/StepupRa/RaBundle/Service/YubikeyService.php

@@ -20,9 +20,9 @@
 
 use GuzzleHttp\Client;
 use Psr\Log\LoggerInterface;
+use RuntimeException;
 use Surfnet\StepupBundle\Http\JsonHelper;
 use Surfnet\StepupRa\RaBundle\Command\VerifyYubikeyOtpCommand;
-use RuntimeException;
 
 class YubikeyService
 {

src/Surfnet/StepupRa/RaBundle/Tests/TestDouble/Service/YubikeySecondFactorService.php

@@ -23,7 +23,6 @@
 use Surfnet\StepupRa\RaBundle\Command\VerifyYubikeyPublicIdCommand;
 use Surfnet\StepupRa\RaBundle\Service\YubikeySecondFactor\VerificationResult;
 use Surfnet\StepupRa\RaBundle\Service\YubikeySecondFactorServiceInterface;
-use Surfnet\StepupRa\RaBundle\Service\YubikeyService;
 
 
 /**

src/Surfnet/StepupRa/RaBundle/Value/DateTime.php

@@ -20,8 +20,8 @@
 
 use DateInterval;
 use DateTime as CoreDateTime;
-use Surfnet\StepupRa\RaBundle\Exception\InvalidArgumentException;
 use Stringable;
+use Surfnet\StepupRa\RaBundle\Exception\InvalidArgumentException;
 
 /**
  * @SuppressWarnings(PHPMD.TooManyPublicMethods) due to comparison methods

src/Surfnet/StepupRa/RaBundle/Value/RoleAtInstitution.php

@@ -18,8 +18,6 @@
 
 namespace Surfnet\StepupRa\RaBundle\Value;
 
-use Surfnet\StepupRa\RaBundle\Assert;
-
 class RoleAtInstitution
 {
     private ?string $role = null;

src/Surfnet/StepupRa/RaBundle/Value/TimeFrame.php

@@ -19,8 +19,8 @@
 namespace Surfnet\StepupRa\RaBundle\Value;
 
 use DateInterval;
-use Surfnet\StepupRa\RaBundle\Exception\InvalidArgumentException;
 use Stringable;
+use Surfnet\StepupRa\RaBundle\Exception\InvalidArgumentException;
 
 final readonly class TimeFrame implements Stringable
 {