C++: Fix code generation for union field types that are constructed with allocators #325
+313
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith allocators - Added initialization constructor to std::variant instance used by union composite types in c++17 and above - Added initialization logic in allocator constructors for union_value member of union composite types
…g constructor support for all c++ versions
ghost
marked this pull request as draft
| VariantType(nunavut::support::in_place_index_t<I> i, Args&&... args) : | ||
| Base{std::in_place_index_t<I>{}, std::forward<Args>(args)...} | ||
| { | ||
| (void)i; // avoid unused param warning |
There was a problem hiding this comment.
I think you can just omit i in the constructor.
|
ghost
marked this pull request as ready for review
thirtytwobits
requested changes
Jan 23, 2024
| rhs: str = "" | ||
| leading_args: typing.List[str] = [] | ||
| trailing_args: typing.List[str] = [] | ||
| if needs_variant_init_args(composite_subtype): |
There was a problem hiding this comment.
false branch not covered in python test
| if language.get_option("ctor_convention") == ConstructorConvention.UsesLeadingAllocator.value: | ||
| leading_args.extend(["std::allocator_arg", "allocator"]) | ||
| else: | ||
| trailing_args.append("allocator") |
There was a problem hiding this comment.
not covered in python test
|
|
||
| if needs_vla_init_args(instance, special_method): | ||
| constructor_args = language.get_option("variable_array_type_constructor_args") | ||
| if isinstance(constructor_args, str) and len(constructor_args) > 0: |
There was a problem hiding this comment.
false branch not covered in python test.
|
|
||
| return value_initializer | ||
| @template_language_test(__name__) |
There was a problem hiding this comment.
this filter not coverend in python tests.
| } | ||
|
|
||
| /** | ||
| * Verify that the variant value can be fetched only at the alternative index for the type being held |
There was a problem hiding this comment.
Missing a test that actually passes an allocator through to a variant type constructor.
|
Closing as abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in_place_index_tto nunavut support library; adds the resource in c++14, referencesstd::in_place_index_tin c++17 buildsnunavut::support::in_place_index_tthat specifies the alternative type to holdunion_valuemember of union composite types is now generated, with appropriate parameters, in copy and move constructors with allocatorsVariantTypeinternal logic withIndexOfproperty