Fix for issue 370 : C++ generator deserialization #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thirtytwobits
approved these changes
Jan 13, 2025
pavel-kirienko
approved these changes
Jan 15, 2025
| @@ -222,20 +222,26 @@ | |||
| {% set ref_size_bytes = 'size_bytes' |to_template_unique_name %} | |||
| {% set ref_delimiter = 'dh' |to_template_unique_name %} | |||
| { | |||
| {{ typename_unsigned_length }} {{ ref_size_bytes }} = in_buffer.size() / 8U; | |||
| {{ typename_unsigned_length }} {{ ref_size_bytes }}; | |||
There was a problem hiding this comment.
A default initializer is needed anyway. The old construct seems fine; the optimizer will throw the extra assignment away anyway, then you can remove the else branch at the bottom.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #370