Use custom warnings and exceptions #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#451 This makes it easier to disambiguate warnings from flatten-tool versus those from other sources.
#450 This makes it easier to diambiguate errors deliberately raised by flatten-tool versus those from other sources. I've left alone a few exceptions that flatten-tool raises, but which we don't expect to happen, so didn't seem to be in the same category.
|
@jpmckinney Does this PR resolve your 2 most recent issues? |
|
Looks good, thank you! |
R2ZER0
reviewed
Aug 6, 2024
| @@ -239,11 +240,13 @@ def unflatten( | |||
| """ | |||
|
|
|||
| if input_format is None: | |||
| raise Exception("You must specify an input format (may autodetect in future") | |||
| raise FlattenToolError( | |||
| "You must specify an input format (may autodetect in future" | |||
There was a problem hiding this comment.
Not related to this PR, but I'm guessing there's meant to be a ) at the end of the message
R2ZER0
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#450 #451