RC2 fixes + improvements #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix PsyX PGXP performance
…nto develop-SoapyMan
- misc stuff
- updated readme
SoapyMan
force-pushed
the
develop-SoapyMan
branch
from
9f3a606
to
76db6e8
Compare
…nto develop-SoapyMan
SoapyMan
force-pushed
the
develop-SoapyMan
branch
from
f0c3ba1
to
685cee7
Compare
Fireboyd78
reviewed
Feb 17, 2024
There was a problem hiding this comment.
Regarding 6d7370a:
Why couldn't this have been resolved through a typedef wrapped in an #if block? I consider this to be a breaking change because of the fact it changes core PSX/XMPlay types. Yes, a long is also 32 bits, but there's clearly a reason for that distinction.
I would strongly recommend finding another solution for this. There is absolutely a better way to handle this.
SoapyMan
force-pushed
the
develop-SoapyMan
branch
from
6d7370a
to
98f3256
Compare
SoapyMan
force-pushed
the
develop-SoapyMan
branch
from
98f3256
to
d829145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.