Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all three dithering methods #213

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

tader
Copy link
Contributor

@tader tader commented Dec 8, 2024

OpenEPaperLink allows for three dithering options:

  • disabled
  • floyd-steinberg
  • ordered

With the dither option as bool, we were limited to two of these options, now as int, we can have all! It defaults to option 2, ordered dithering.

@tader tader marked this pull request as draft December 8, 2024 14:36
@tader tader force-pushed the dev branch 4 times, most recently from 505c2c9 to 6947a61 Compare December 8, 2024 14:47
@tader tader marked this pull request as ready for review December 8, 2024 14:47
@tader tader force-pushed the dev branch 2 times, most recently from 70ae4a6 to de3bd5f Compare December 8, 2024 14:53
@jonasniesner
Copy link
Member

Is this pr ready to be merged?

@tader
Copy link
Contributor Author

tader commented Dec 9, 2024

Is this pr ready to be merged?

Yes, please merge 👍

@g4bri3lDev g4bri3lDev merged commit 2588305 into OpenEPaperLink:dev Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants