Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include feedback for linkedData section #172 #176

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Include feedback for linkedData section #172 #176

merged 3 commits into from
Oct 22, 2024

Conversation

Ludee
Copy link
Member

@Ludee Ludee commented Oct 21, 2024 •
edited by jh-RLI
Loading

Summary of the discussion

  • remove keys: "user", "@type" and "usedResource" they are part of the databus/moss and should not be in the oemetadata.
  • remove section "linkedData" and move keys "@id" "@context" to the resource

Type of change (CHANGELOG.md)

Removed

  • Remove linkedData section and keys (#176)

Workflow checklist

Automation

Closes #172

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee added the type: bug 🐛 Something isn't working label Oct 21, 2024
@Ludee Ludee requested a review from jh-RLI October 21, 2024 21:47
@Ludee Ludee self-assigned this Oct 21, 2024
@Ludee Ludee marked this pull request as ready for review October 21, 2024 21:49
jh-RLI
jh-RLI approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this :)

@jh-RLI jh-RLI merged commit d168f00 into develop Oct 22, 2024
2 checks passed
@jh-RLI jh-RLI deleted the feature-172-feedback-ld branch October 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jh-RLI jh-RLI jh-RLI approved these changes

Assignees

@Ludee Ludee

Labels
type: bug 🐛 Something isn't working
Projects
OEMetadata v2.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback: Linked data information should not be nested to much and some keys can be removed
2 participants
@Ludee @jh-RLI