Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-178-enhance-spatial-section #179

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

jh-RLI
Copy link
Contributor

@jh-RLI jh-RLI commented Oct 22, 2024

Summary of the discussion

This PR enhances the spatial information of the oemetadata. It includes new keys for extensive spatial information which need to be discussed further. This includes fields for boundingBox to better describe the extend of the data and also crs information for better reusability of the data.

The "extent" field was reworked to be able to link to external resources that define region names like "Europe" and provide additional information. An @id key was introduced.

The "resolution" was also reworked to make the information more machine readable and also more clear to the user as fields that must hold non atomic information seems to raise confusion as the use case is not well specified.

The original objective of this PR is to resolve the "location" key and introduce more explicit "lat" "lon" key. To keep the human readable address information i suggest to add a address field.

"spatial": {
    "location": {
        "address": "", 
        "@id": "", 
        "latitude": "", 
        "longitude": "" },
    "extent": {
        "name": "", 
        "@id": "", 
        "resolutionValue": "", 
        "resolutionUnit": "", 
        "boundingBox": [,,,], 
        "crs": ""}}

Type of change (CHANGELOG.md)

Updated

  • Refactor the spatial section and add new keys for location: 'address', '@id', 'latitude', 'longitude' and for extent: 'name', '@id', 'resolutionValue', 'resolutionUnit', 'boundingBox', 'crs' (#179)

Workflow checklist

Automation

Closes #178

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee self-assigned this Oct 22, 2024
@Ludee Ludee added part: documentation 📖 Improvements or additions to documentation type: enhancement ⚙️ Improvement of an existing feature labels Oct 22, 2024
@Ludee Ludee self-requested a review October 22, 2024 18:23
@Ludee
Copy link
Member

Ludee commented Oct 22, 2024

"spatial": {
    "location": {
        "address": "", 
        "@id": "", 
        "latitude": "", 
        "longitude": "" },
    "extent": {
        "name": "", 
        "@id": "", 
        "boundingBox": [,,,], 
        "resolutionValue": "", 
        "resolutionUnit": "", 
        "crs": ""}}

@Ludee
Copy link
Member

Ludee commented Oct 22, 2024

"spatial": {
    "location": {
        "address": "Rudower Chaussee 12, 12489 Berlin", 
        "@id": "https://www.wikidata.org/wiki/Q77077223", 
        "latitude": "52.432822", 
        "longitude": "13.5351004" },
    "extent": {
        "name": null, 
        "@id": null, 
        "boundingBox": null, 
        "resolutionValue": null, 
        "resolutionUnit": null, 
        "crs": null}}

@Ludee
Copy link
Member

Ludee commented Oct 22, 2024

"spatial": {
    "location": {
        "address": null, 
        "@id": null, 
        "latitude": null, 
        "longitude": null },
    "extent": {
        "name": "Berlin", 
        "@id": "https://www.wikidata.org/wiki/Q64", 
        "boundingBox": [13.08825, 52.33859, 13.76104, 52.6754], 
        "resolutionValue": "100", 
        "resolutionUnit": "m", 
        "crs": "EPSG:4326"}}

[minLon (W), minLat (S), maxLon (E), maxLat (N)]
13.08825, 52.33859, 13.76104, 52.6754
coordinates of easternmost point 52.43766, 13.76104
coordinates of northernmost point 52.6754, 13.47944
coordinates of southernmost point 52.33859, 13.64817
coordinates of westernmost point 52.41961, 13.08825

@Ludee
Copy link
Member

Ludee commented Oct 22, 2024

"spatial": {
    "location": {
        "address": null, 
        "@id": null, 
        "latitude": null, 
        "longitude": null },
    "extent": {
        "name": "Germany", 
        "@id": "https://www.wikidata.org/wiki/Q183", 
        "boundingBox": null, 
        "resolutionValue": null, 
        "resolutionUnit": "federal state", 
        "crs": null}}

Copy link
Member

@Ludee Ludee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice concept! Thanks a lot @jh-RLI and @christian-rli

@Ludee Ludee merged commit 3f7bd20 into develop Oct 22, 2024
2 checks passed
@Ludee Ludee deleted the feature-178-enhance-spatial-section branch October 22, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: documentation 📖 Improvements or additions to documentation type: enhancement ⚙️ Improvement of an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feedback: The section for spatial information needs to be improved
2 participants