Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v2.0.0 Halloween Special 🎃🍭🍬🍾 #200

Merged
merged 342 commits into from
Oct 31, 2024
Merged

Release v2.0.0 Halloween Special 🎃🍭🍬🍾 #200

merged 342 commits into from
Oct 31, 2024

Conversation

Ludee
Copy link
Member

@Ludee Ludee commented Oct 30, 2024 •
edited
Loading

Closes #197

Ludee and others added 30 commits October 12, 2024 00:42
@Ludee
Add roles #137
cc39a51
@Ludee
Update title description #137
94d0125
@Ludee
Update key description #137
f76da01
@Ludee
Update changelog #140
7b671ce
@Ludee
Update README
07aad52
@Ludee
Update changelog #137
18f7859
@jh-RLI
Merge pull request #157 from OpenEnergyPlatform/feature-137-contributors
a06b6be 
Update the contributors section #137 #142 #151
@Ludee
Merge branch 'develop' of github.com:OpenEnergyPlatform/metadata into…
ac58c69 
… develop
@jh-RLI
Merge branch 'develop' into feature-140-embargo
7431514
@jh-RLI
Merge pull request #155 from OpenEnergyPlatform/feature-140-embargo
1210ff4 
Add embargo period to general keys #140
@jh-RLI
Merge pull request #154 from OpenEnergyPlatform/feature-153-contextjson
0a4cd7c 
Add an updated version of context.json #153
@Ludee
Add section for keys and update examples #158
5666302
@Ludee
Update json structre #158
d0bad3d
@Ludee
Update id for automation #158
03e7d35
@Ludee
Update metadata name in metaMeta #158
4ea2279
@Ludee
Update definitions #158
4027ca4
@Ludee
Update documentation #158
39c7db6
@Ludee
Rename filename #158
74011f6
@Ludee
Merge branch 'develop' of github.com:OpenEnergyPlatform/metadata into…
e020be9 
… develop
@Ludee
Update descriptions and add mandatory #40
1f31cac
@Ludee
Update descriptions #40
852ff6b
@Ludee
Update descriptions and add mandatory key #40
949c2cb
@Ludee
Add mandatory field #40
a009bc0
@Ludee
Remove double resource section #40
ed1a5bc
@Ludee
Add mandartory fields to resource section #40
9c10dcf
@Ludee
Update changelog #40
c05940d
@jh-RLI
Merge pull request #160 from OpenEnergyPlatform/feature-40-mandatory
5900bab 
Specify the mandatory fields to the json schema
@Ludee
Add key isNullable to fields section #96
e6565a6
@Ludee
Sort the key unit #96
7676026
@Ludee
Rename to nullable #96
1bf1456
@Ludee Ludee changed the title Release v2.0.0 Release v2.0.0 Halloween Special Oct 30, 2024
@Ludee Ludee changed the title Release v2.0.0 Halloween Special Release v2.0.0 Halloween Special 🍭🍬🍾 Oct 30, 2024
@Ludee Ludee requested a review from henhuy October 30, 2024 23:55
@Ludee Ludee marked this pull request as ready for review October 30, 2024 23:55
@Ludee Ludee removed the request for review from chrwm October 31, 2024 11:08
jh-RLI
jh-RLI approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this seems fine. As we discussed you must move the content from v20 to latest directory (replace everything in latest) and then there is a bit of a struggle to update the paths/urls in the example to ".../latest/..." instead of ".../v20/..."

🎃

@Ludee Ludee changed the title Release v2.0.0 Halloween Special 🍭🍬🍾 Release v2.0.0 Halloween Special 🎃🍭🍬🍾 Oct 31, 2024
christian-rli
christian-rli approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@christian-rli christian-rli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@jh-RLI
Copy link
Contributor

jh-RLI commented Oct 31, 2024

Ah i forgot to mention that you also have to move the tests.

@jh-RLI
Copy link
Contributor

jh-RLI commented Oct 31, 2024

i can do that

@Ludee Ludee removed the request for review from henhuy October 31, 2024 13:49
@Ludee Ludee merged commit 16364bc into master Oct 31, 2024
@Ludee Ludee deleted the release-v2.0.0 branch October 31, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jh-RLI jh-RLI jh-RLI approved these changes

@christian-rli christian-rli christian-rli approved these changes

Assignees

@Ludee Ludee

Labels
part: documentation 📖 Improvements or additions to documentation type: enhancement ⚙️ Improvement of an existing feature
Projects
OEMetadata v2.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ludee @jh-RLI @christian-rli