Hotfix 533 xml download yesterday misses gen url #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If applied, this commit will close issue OpenEnergyPlatform#533 by adding the missing call to gen_url.
Additionally deleted two comments that I think are not necessary to understand the code
|
Tests are failing as usual for PRs from outside, as the github secret API credentials are not exposed to PRs from outside. Hence we would need to merge without tests and see the test results before we do the next release. |
FlorianK13
approved these changes
Jun 6, 2024
|
I've checked the PR, added a few small changes and approved it. Big thanks to @wok77 for pointing this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If accpeted, this commit will close issue #533 by adding the missing call to gen_url in open_mastr/xml_download/utils_download_bulk.py
Workflow checklist
Automation
Close #533
PR-Assignee
Reviewer