Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 553 pandas numpy version #554

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix 553 pandas numpy version #554

merged 2 commits into from
Aug 27, 2024

Conversation

nesnoj
Copy link
Collaborator

@nesnoj nesnoj commented Aug 27, 2024

Summary of the discussion

Fixes compatibility issues of pandas and numpy.

Type of change (CHANGELOG.md)

Updated

  • Set pandas version to >=2.2.2 for compatibility with numpy v2.0
    #553

Workflow checklist

Automation

Closes #553

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@nesnoj nesnoj added the 🐛 bug Something isn't working label Aug 27, 2024
@nesnoj nesnoj requested a review from FlorianK13 August 27, 2024 10:11
@nesnoj nesnoj self-assigned this Aug 27, 2024
@FlorianK13
Copy link
Member

@nesnoj until now we never had a clear rule for who is merging the PR:

  • The Reviewer after the PR is approved
  • The Creator of the PR after it was approved

What do you think?

@nesnoj
Copy link
Collaborator Author

nesnoj commented Aug 27, 2024

@nesnoj until now we never had a clear rule for who is merging the PR:

  • The Reviewer after the PR is approved
  • The Creator of the PR after it was approved

What do you think?

Thx for your quick reply!
I understand the reviewer to only review the PR and the assignee (in this case me) to merge it. For example if I made small mistakes which I wanna fix (and which do not require a re-review) or if I wait for the tests to complete..
So reviewer review, assignee merge it, ok? :)

@nesnoj nesnoj merged commit 08a14ce into develop Aug 27, 2024
9 checks passed
@nesnoj nesnoj deleted the fix-553-pandas-numpy-version branch August 27, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants