-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualization of HydroDyn Morison mesh and MoorDyn lines #1768
Conversation
One suggested change from @ebranlard that I really like is to modify the way It would be really nice to add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing that.
My only comment would indeed be to try and add a connectivity field to the point mesh for visualization purposes. But this can be done in another pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally agree with the approach suggested by Emmanuel, which is what we discussed before. But this is a fine stop-gap solution. Please find only a couple small comments.
Perhaps we can circle back to the approach suggested by Emmanuel when we add support for rectangular members in HydroDyn and SubDyn, which is code development planned in the future. Other changes to this visualization implementation will be required at that point anyway.
|
||
! map the motion to the visulization mesh | ||
if (p%VisMeshes) then | ||
!FIXME: error handling is incorrect here (overwrites all previous errors/warnings) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be fixed before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a significant amount of reworking of the error handling in Morison required to really address this. Since there are more HydroDyn changes in the dev
and dev-unstable
branches, I would rather wait and deal with error handling there instead of introduce potential merge conflicts now.
ErrStat = ErrStat2, & | ||
ErrMess = ErrMsg2, & | ||
TranslationDisp = .TRUE., & | ||
Orientation = .TRUE. ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better if this VisMesh had the same fields as the Morison input point mesh (including velocities and accelerations)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we don't need the velocities in the VisMesh -- it's pretty rare to use them during visualization and they still exist in the Morison mesh. Switching to adding the connectivity to the point meshes will include that information at that point.
… modeled and fix typo in previous commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for responding. I'm fine with merging this in now.
Dear @andrew-platt, Could you release the files used to visualise the 5MW test, that I can run in ParaView to visualise the Morison mooring elements and floating platform? I'm having trouble setting this up for my own platform configuration. Regards, |
Dear @cillianfrawley, This feature is available with the OpenFAST version 3.5.1 release. See the release notes page for the executables and links to the input files here: https://github.com/OpenFAST/openfast/releases/tag/v3.5.1 The models above are found in the regression tests as the
Regards, |
Thanks Andy, I have that partially running, however, I run into the following issue when displaying the .vtp files in Paraview. This might be a question for elsewhere but why does the platform surface not show (I can only display it by clicking the 'point Gaussian' in the drop-down option). Also, I can't display the mooring lines as in your picture. |
Hi @cillianfrawley, Are you using version 3.5.1? 3.5.0 and earlier versions could not output the mooring lines or the surfaces of the HydroDyn mesh. |
Hi @andrew-platt, Apologies I'm new to GitHub and its file system, V3.5.0 was installed as well as V3.5.1 so I thought I was using the new version but it was running the new files with the old version. All is working great now, thanks for the help! |
This PR is ready to merge.
Feature or improvement description
Since v2.6 it has not been easily possible to visualize HydroDyn or SubDyn meshes. This PR adds visualization to both the HydroDyn Morrison elements and to the MoorDyn lines. To accomplish this, MoorDyn outputs a
line2
mesh when visualization is turned on. HydroDyn creates a newline2
mesh that is mapped from theu%mesh
(different number of nodes) when visualization is requested.It is now possible to quickly visualize the following:
VTK_Type=1
; linesVTK_Type=2
)VTK_Type=1
andVTK_Type=2
)VTK_Type=1
; lines:VTK_Type=2
)Figure:
5MW_OC4Semi
test case with large waves.WrVTK=2
andVTK_type=1
.Some features are not currently implemented:
Related issue, if one exists
#776 -- This PR does not address the SubDyn visualization mentioned there.
#539 -- fully addressed
Impacted areas of the software
MoorDyn, HydroDyn, and a small amount of glue code.
Additional supporting information
During the implementation of the flexible floater option with SubDyn for v2.6, the mesh types were changed from line2 to point meshes. This made it more difficult to use Paraview to visualize the mesh structures.
Test results, if applicable
No tests cases change (we do not generate vtk outputs during test cases due to the amount of data).