-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.0.1 #2622
Merged
Merged
Release 4.0.1 #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal damping, and/or quadratic translational damping for bodies in an optional section of the input file
…damping approach
Combining Rod Damping and improving input file format
…ther defined in the global earth-fixed coordinate system or the local body-fixed coordinate system through a new input switch External force and damping of point objects must always be in the global coordinate system due to a lack of rotational DoFs. The distributed transverse and axial damping of rod objects only make sense in the local body-fixed coordinate system. The behavior of external force on rod objects need to be clarified in the future.
…on with the coordinate system flag for rod and point objects
Change the `!$OMP critical(fileopen)` statements to `!$OMP critical(fileopen_critical)` and fix a few misnamed critical statements A `!$OMP critical(filename)` in AD was causing Intel to fail to compile with OMP enabled due to `filename` being used as a variable in the same routine (GCC didn't care)
[BugFix] OMP critical names preventing Intel+OMP compilation
…quad entries for rod objects
… into of_io_update
Windows VS build -- stack overflow with FAST.Farm
AD bugfix: aerodyn driver non-OLAF combined cases don't update wind
OutVTKdir --> OutVTKDir for consistency
These were badly outdated
…l force and damping
Post release
|
MD: User-specified external forces and translational damping for MoorDyn point, rod, and body objects
|
Bugfix: Update create_FAST_SFunc.m for Windows, update docs on Simulink MEX building
deslaughter
approved these changes
Jan 30, 2025
mayankchetan
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thank you for pushing this so quick!!
Co-authored-by: Mayank Chetan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on merging of #2621, #2597, and updates to release notes/version stuff.
Feature or improvement description
Pull request to merge
rc-4.0.1
intomain
and create a tagged release for v4.0.1See the milestone and project pages for additional information
Test results, if applicable
See GitHub Actions
Release checklist:
AeroDyn_Driver_x64.exe
AeroDyn_Driver_x64_OpenMP.exe
AeroDyn_Inflow_C_Binding_x64.dll
AeroDyn_Inflow_C_Binding_x64_OpenMP.dll
BeamDyn_Driver_x64.exe
DISCON.dll (x64)
DISCON_ITIBarge.dll (x64)
DISCON_OC3Hywind.dll (x64)
DISCON_SC.dll (x64)
FAST.Farm_x64.exe
FAST.Farm_x64_OMP.exe
FAST_SFunc.mexw64
HydroDynDriver_x64.exe
HydroDyn_C_Binding_x64.dll
IfW_C_Binding_x64.dll
InflowWind_Driver_x64.exe
InflowWind_Driver_x64_OpenMP.exe
MoorDyn_Driver_x64.exe
MoorDyn_C_Binding_x64.dll
OpenFAST-Simulink_x64.dll
openfast_x64.exe
SubDyn_x64.exe
Turbsim_x64.exe
Changelog
Overview
This release includes multiple small bug-fixes including compilation issues with Flang and Intel (IFX), improved diagnostics for the AeroDyn_Inflow_c-binding interface, user specified external loads and damping for MoorDyn,
Wind_IO
updates, a fix for a stack overflow with FAST.Farm built with Visual Studio on Windows, and other minor bugfixes.General
Wind_IO
#2603 updates to handle writing OpenFAST models from weis and wind_io (mayankchetan)
Build systems
#2607 Windows VS build -- stack overflow with FAST.Farm (andrew-platt)
#2619 ROCM Flang doesn't compile NWTC_IO.f90 (andrew-platt)
#2621 Bugfix: Update create_FAST_SFunc.m for Windows, update docs on Simulink MEX building (andrew-platt)
Module changes
AeroDyn
#2609 AD bugfix: aerodyn driver non-OLAF combined cases don't update wind (andrew-platt)
#2615 Improve diagnostics for ADI_c interface coupling (andrew-platt)
MoorDyn
#2597 MD: User-specified external forces and translational damping for MoorDyn point, rod, and body objects (luwang00)
Input file changes
No input file changes are required from 4.0.0. MoorDyn can contain an optional section for
External Loads
.Full list of changes: https://openfast.readthedocs.io/en/main/source/user/api_change.html
Full input file sets: https://github.com/OpenFAST/r-test/tree/v4.0.1 (example input files from the regression testing)