Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0.1 #2622

Merged
merged 53 commits into from
Jan 31, 2025
Merged

Release 4.0.1 #2622

merged 53 commits into from
Jan 31, 2025

Conversation

andrew-platt
Copy link
Collaborator

@andrew-platt andrew-platt commented Jan 30, 2025

Waiting on merging of #2621, #2597, and updates to release notes/version stuff.

Feature or improvement description
Pull request to merge rc-4.0.1 into main and create a tagged release for v4.0.1

See the milestone and project pages for additional information

https://github.com/OpenFAST/openfast/milestone/16

Test results, if applicable
See GitHub Actions

Release checklist:

  • Update the documentation version in docs/conf.py
  • Update the versions in docs/source/user/api_change.rst
  • Verify readthedocs builds correctly
  • Create a tag in OpenFAST
  • Create a merge commit in r-test and add a corresponding annotated tag
  • Compile executables for Windows builds
    • AeroDyn_Driver_x64.exe
    • AeroDyn_Driver_x64_OpenMP.exe
    • AeroDyn_Inflow_C_Binding_x64.dll
    • AeroDyn_Inflow_C_Binding_x64_OpenMP.dll
    • BeamDyn_Driver_x64.exe
    • DISCON.dll (x64)
    • DISCON_ITIBarge.dll (x64)
    • DISCON_OC3Hywind.dll (x64)
    • DISCON_SC.dll (x64)
    • FAST.Farm_x64.exe
    • FAST.Farm_x64_OMP.exe
    • FAST_SFunc.mexw64
    • HydroDynDriver_x64.exe
    • HydroDyn_C_Binding_x64.dll
    • IfW_C_Binding_x64.dll
    • InflowWind_Driver_x64.exe
    • InflowWind_Driver_x64_OpenMP.exe
    • MoorDyn_Driver_x64.exe
    • MoorDyn_C_Binding_x64.dll
    • OpenFAST-Simulink_x64.dll
    • openfast_x64.exe
    • SubDyn_x64.exe
    • Turbsim_x64.exe

Changelog

Overview

This release includes multiple small bug-fixes including compilation issues with Flang and Intel (IFX), improved diagnostics for the AeroDyn_Inflow_c-binding interface, user specified external loads and damping for MoorDyn, Wind_IO updates, a fix for a stack overflow with FAST.Farm built with Visual Studio on Windows, and other minor bugfixes.

General

Wind_IO

#2603 updates to handle writing OpenFAST models from weis and wind_io (mayankchetan)

Build systems

#2607 Windows VS build -- stack overflow with FAST.Farm (andrew-platt)

#2619 ROCM Flang doesn't compile NWTC_IO.f90 (andrew-platt)

#2621 Bugfix: Update create_FAST_SFunc.m for Windows, update docs on Simulink MEX building (andrew-platt)

Module changes

AeroDyn

#2609 AD bugfix: aerodyn driver non-OLAF combined cases don't update wind (andrew-platt)

#2615 Improve diagnostics for ADI_c interface coupling (andrew-platt)

MoorDyn

#2597 MD: User-specified external forces and translational damping for MoorDyn point, rod, and body objects (luwang00)

Input file changes

No input file changes are required from 4.0.0. MoorDyn can contain an optional section for External Loads.

Full list of changes: https://openfast.readthedocs.io/en/main/source/user/api_change.html

Full input file sets: https://github.com/OpenFAST/r-test/tree/v4.0.1 (example input files from the regression testing)

luwang00 and others added 30 commits January 2, 2025 18:23
…onal damping, and/or quadratic translational damping for bodies in an optional section of the input file
Combining Rod Damping and improving input file format
…ther defined in the global earth-fixed coordinate system or the local body-fixed coordinate system through a new input switch

External force and damping of point objects must always be in the global coordinate system due to a lack of rotational DoFs. The distributed transverse and axial damping of rod objects only make sense in the local body-fixed coordinate system. The behavior of external force on rod objects need to be clarified in the future.
…on with the coordinate system flag for rod and point objects
Change the `!$OMP critical(fileopen)` statements to `!$OMP critical(fileopen_critical)` and fix a few misnamed critical statements

A `!$OMP critical(filename)` in AD was causing Intel to fail to compile with OMP enabled due to `filename` being used as a variable in the same routine (GCC didn't care)
[BugFix] OMP critical names preventing Intel+OMP compilation
Windows VS build -- stack overflow with FAST.Farm
AD bugfix: aerodyn driver non-OLAF combined cases don't update wind
OutVTKdir --> OutVTKDir for consistency
@andrew-platt andrew-platt added this to the v4.0.1 milestone Jan 30, 2025
@andrew-platt andrew-platt self-assigned this Jan 30, 2025
@andrew-platt andrew-platt changed the title Rc 4.0.1 Release 4.0.1 Jan 30, 2025
@andrew-platt andrew-platt marked this pull request as draft January 30, 2025 06:27
@andrew-platt andrew-platt requested a review from jjonkman January 30, 2025 06:28
@andrew-platt
Copy link
Collaborator Author

andrew-platt commented Jan 30, 2025

Post release

MD: User-specified external forces and translational damping for MoorDyn point, rod, and body objects
@andrew-platt
Copy link
Collaborator Author

  • tag r-test as well (new test case, no changes to old)

@andrew-platt andrew-platt marked this pull request as ready for review January 30, 2025 20:23
Bugfix: Update create_FAST_SFunc.m for Windows, update docs on Simulink MEX building
Copy link
Contributor

@mayankchetan mayankchetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thank you for pushing this so quick!!

docs/changelogs/ReleaseProcess.md Outdated Show resolved Hide resolved
openfast_io/openfast_io/FAST_writer.py Outdated Show resolved Hide resolved
@andrew-platt andrew-platt merged commit 89358f1 into main Jan 31, 2025
23 checks passed
@andrew-platt andrew-platt deleted the rc-4.0.1 branch January 31, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants