Fix type to prevent implicit type conversion: uint32_t instead of uint16_t #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an implicit type conversion in ofp_netif.c, where an uint16_t is used instead of an uint32_t.
Background and impact of this bug:
pcap-implementation (in pcap.c) of pktio interface initializes mtu-size with:
pcap->mtu = PKTIO_PCAP_MTU_MAX;
whereas PKTIO_PCAP_MTU_MAX is defined as:
#define PKTIO_PCAP_MTU_MAX (64 * 1024)
.64*1024 = 0x00010000
, when casted to uint16_t this is 0.Using the pcap implementation causes the following error: