Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Using cofactors example notebook #91

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP] Using cofactors example notebook #91

wants to merge 4 commits into from

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Dec 11, 2023

This probably needs to be a cookbook instead - pinging @dwhswenson and @hannahbaumann for thoughts here.

Copy link

Binder 👈 Launch a binder notebook on branch OpenFreeEnergy/ExampleNotebooks/cofactors

@hannahbaumann
Copy link
Contributor

I like this! How do people usually find out that an example notebook for a specific problem exists? If it's easier to find the cookbook, it might be good adding that as well?

Copy link
Contributor

@richardjgowers richardjgowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notebook is good except for the manual charge generation which takes a long while to complete. I understand the reason for this, but to make the notebook flow interactively could we instead save sdfs with partial charges pre-calculated and use these. Then keep the cell for partial charge generation behind a if False: branch so people can opt into it / see how it's done.

@jthorton
Copy link
Contributor

@IAlibay would you like me to take over this? I think this would be great to add as a cookbook!

@IAlibay
Copy link
Member Author

IAlibay commented Oct 25, 2024

@jthorton please do!

@jthorton jthorton assigned jthorton and unassigned richardjgowers Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showcase: Document possible options in mapping Showcase: Write proper introduction to showcase notebook
4 participants