Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the alchemiscale KeyedChain with new gufe KeyedChain #329

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

ianmkenney
Copy link
Collaborator

KeyedChains are now implemented in gufe. This PR removes their implementation in alchemiscale.

closes #328

@ianmkenney ianmkenney self-assigned this Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.01%. Comparing base (7099ce6) to head (3ee96c4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   80.21%   80.01%   -0.20%     
==========================================
  Files          27       26       -1     
  Lines        3507     3472      -35     
==========================================
- Hits         2813     2778      -35     
  Misses        694      694              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@dotsdl dotsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @ianmkenney! Looks great!

@dotsdl dotsdl merged commit 11eda18 into main Nov 20, 2024
6 of 7 checks passed
@dotsdl dotsdl deleted the feature/replace-keyedchain-import branch November 20, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use KeyedChains from gufe
2 participants