Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskStatusDB: Test for _task_row_update_statement #25

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dwhswenson
Copy link
Member

I promised more detailed unit tests for this function in #21. Here they are.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.00% 🎉

Comparison is base (2cffa62) 86.62% compared to head (cd63885) 91.63%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   86.62%   91.63%   +5.00%     
==========================================
  Files           5        5              
  Lines         344      526     +182     
==========================================
+ Hits          298      482     +184     
+ Misses         46       44       -2     
Files Changed Coverage Δ
exorcist/taskdb.py 97.97% <100.00%> (+2.39%) ⬆️
exorcist/tests/test_taskstatusdb.py 99.39% <100.00%> (+0.49%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwhswenson dwhswenson marked this pull request as draft October 5, 2023 18:20
@dwhswenson
Copy link
Member Author

Putting this on hold (as draft) because I think it might have conflicts with #31. Part of this PR involves actually testing the SQL that gets emitted; this was intended as a way to give a clear picture of what is happening behind the scenes. But the SQL that gets emitted might be dialect-specific.

I'll come back to finish this after #31 is merged in (prefer to get that in and have the conflict block here than the other way around).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant