Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "DAG dependency order" in docstrings #244

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Clarify "DAG dependency order" in docstrings #244

merged 1 commit into from
Oct 10, 2023

Conversation

Yoshanuikabundi
Copy link
Contributor

Fixes #223

@pep8speaks
Copy link

Hello @Yoshanuikabundi! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 66:80: E501 line too long (80 > 79 characters)
Line 163:80: E501 line too long (80 > 79 characters)

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dcc7896) 99.18% compared to head (ad6f345) 99.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files          36       36           
  Lines        1838     1838           
=======================================
  Hits         1823     1823           
  Misses         15       15           
Files Coverage Δ
gufe/protocols/protocoldag.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thanks!

@dwhswenson dwhswenson merged commit 1b7c832 into main Oct 10, 2023
15 checks passed
@dwhswenson dwhswenson deleted the issue223 branch October 10, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify ProtocolDAG docstrings
3 participants