Fix CI #348
Fix CI #348
Conversation
IAlibay
commented
Sep 17, 2024
IAlibay
commented
- Add in the shim for macos.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 98.94% 98.79% -0.16%
==========================================
Files 36 36
Lines 1996 1988 -8
==========================================
- Hits 1975 1964 -11
- Misses 21 24 +3 ☔ View full report in Codecov by Sentry. |
| @@ -9,4 +9,4 @@ dependencies: | |||
| - sphinx | |||
| - openmm | |||
| - pip: | |||
| - git+https://github.com/OpenFreeEnergy/ofe-sphinx-theme@main | |||
| - git+https://github.com/OpenFreeEnergy/ofe-sphinx-theme@a45f3edd5bc3e973c1a01b577c71efa1b62a65d6 | |||
There was a problem hiding this comment.
This is a known issue upstream
There was a problem hiding this comment.
Can you link to the issue? I'd like to learn what's going on here so we can follow up later.
There was a problem hiding this comment.
Here we go: OpenFreeEnergy/ofe-sphinx-theme#5
It's a fixaeble packaging issue but I've not had time to look into it.
| @@ -29,7 +29,8 @@ jobs: | |||
| cache-environment: true | |||
| cache-downloads: true | |||
| create-args: >- | |||
| python=3.9 | |||
| python=3.10 | |||
| rdkit=2023.09.5 | |||
There was a problem hiding this comment.
I've never been able to work that one out.
There was a problem hiding this comment.
@IAlibay can you elaborate? Work what out here?
There was a problem hiding this comment.
For some reason or another mypy has been complaining about a certain error with rdkit 2024+. Something about self being defined twice for a certain object.
Our approach has just been to pin to an older version of rdkit, but honestly we should try to fix it properly.
| @@ -29,7 +29,8 @@ jobs: | |||
| cache-environment: true | |||
| cache-downloads: true | |||
| create-args: >- | |||
| python=3.9 | |||
| python=3.10 | |||
| rdkit=2023.09.5 | |||
There was a problem hiding this comment.
@IAlibay can you elaborate? Work what out here?
| @@ -9,4 +9,4 @@ dependencies: | |||
| - sphinx | |||
| - openmm | |||
| - pip: | |||
| - git+https://github.com/OpenFreeEnergy/ofe-sphinx-theme@main | |||
| - git+https://github.com/OpenFreeEnergy/ofe-sphinx-theme@a45f3edd5bc3e973c1a01b577c71efa1b62a65d6 | |||
There was a problem hiding this comment.
Can you link to the issue? I'd like to learn what's going on here so we can follow up later.
It's because we've changed the matrix and some of the checks are enforced as "necessary" in the gufe repo settings, so github is waiting for runners that don't exist. |
