[WIP] - Fe setup structure alchemical network planning #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are few discussion points left.
give the gufe files are more logic structure (grouping by function).
…em_generator to gufe
|
@IAlibay and @jameseastwood depending on interest, this needs to be re-assigned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we try to do something we actually wanted to do aeons ago. :)
here we try to transfer the Abstract classes from OpenFE to gufe, to make the accessible to a broader developer community as a starting point:
https://github.com/OpenFreeEnergy/openfe/blob/main/openfe/setup/chemicalsystem_generator/abstract_chemicalsystem_generator.py
https://github.com/OpenFreeEnergy/openfe/blob/main/openfe/setup/alchemical_network_planner/abstract_alchemical_network_planner.py
These classes are part of the current model for setting up FE network plans (that generat alchemical networks). Currently in OpenFE there are two realizations of the
AlchemicalNetworkPlanner(RHFE and RBFE) and one of theChemicalSystemGenerator(used in theAlchemicalNetworkPlanner. Here is the Example workflow for the RBFE-AlchemicalNetworkPlannerThis PR depends on #346