Add gather support for parallel dir structure

[atravitz]

Checklist

• Added a news entry

Developers certificate of origin

• I certify that this contribution is covered by the MIT License here and the Developer Certificate of Origin at https://developercertificate.org/.

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[IAlibay]

Couple comments on the protocol side of things, not read the rest yet.

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.73%. Comparing base (76127a1) to head (f4e753a).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
openfecli/commands/gather.py	77.27%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
- Coverage   94.57%   92.73%   -1.84%     
==========================================
  Files         135      135              
  Lines       10061    10077      +16     
==========================================
- Hits         9515     9345     -170     
- Misses        546      732     +186     

Flag	Coverage Δ
fast-tests	92.73% <90.00%> (?)
slow-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[github-actions]

🚨 API breaking changes detected! 🚨

[hannahbaumann]

Thanks @atravitz , this looks great. Only thing I'm not so sure about yet is the input file path for gather.
I wanted to test this on one of my old result files, however they were in a structure such as this:
all_results with following subfolders:
results_0, results_1, results_2, results_other_setting_0, results_other_setting_1, results_other_setting_2.
If I only want to analyze the results from the first three folders, I'd have to move the other folders in a different directory.
This could be fine, but alternatively, gather could also take a list of Paths. I'm not sure yet what is better, but just wanted to raise this use case.

[IAlibay]

gather could also take a list of Paths.

Just wanted to chime in here that having gather take in a list of results JSON and/or directories would be great (the former more than the latter)! That being said I do think this is maybe something to be dealt with elsewhere.

[atravitz]

I agree with both of you @IAlibay @hannahbaumann - how do you feel about me addressing this in a follow-up PR?

[hannahbaumann]

Thanks @atravitz , lgtm!

[github-actions]

No API break detected ✅