Simplify settings help message #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atravitz
force-pushed
the
simplify_settings_help_message
branch
from
81d0137 to
4e937d0
Compare
|
🚨 API breaking changes detected! 🚨 |
1 similar comment
|
🚨 API breaking changes detected! 🚨 |
|
🚨 API breaking changes detected! 🚨 |
|
🚨 API breaking changes detected! 🚨 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
==========================================
- Coverage 94.57% 92.84% -1.73%
==========================================
Files 135 135
Lines 10061 10061
==========================================
- Hits 9515 9341 -174
- Misses 546 720 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I agree it should give a brief example and then point to the docs which lists all the choices! |
|
I've not read the change but I agree to simplifying too! |
|
🚨 API breaking changes detected! 🚨 |
hannahbaumann
approved these changes
Dec 19, 2024
|
No API break detected ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just my opinion so I'm open to a veto, but I think that CLI help messages should be concise where possible.