-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for variable position/velocity trajectory writing #1083
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
- Coverage 93.49% 91.87% -1.62%
==========================================
Files 142 142
Lines 10527 10608 +81
==========================================
- Hits 9842 9746 -96
- Misses 685 862 +177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ng-tests Write tests for position and velocity writing frequency
@hannahbaumann the defaults would now yield 50 frames per replica, down from 5000 frames per replica, which should be a large enough reduction in size, what do you think? |
Yes, that sounds like a good size! |
I think everything that needs addressing has been addressed, only thing that's blocking is a release of openmmtools and openfe-analysis, but I'll leave it to you to approve @hannahbaumann ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IAlibay , lgtm! We'll just need to change the pin after the openmmtools release.
I'm getting the sense the openmmtools release won't be for a few weeks, so we might have to wait until the next OpenFE release to have this merged. |
No API break detected ✅ |
Checked it out locally, should be good to go. |
Depends on: choderalab/openmmtools#767
Also see: OpenFreeEnergy/openfe_analysis#44
TODO:
main
news
entryDevelopers certificate of origin