Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just don't install espaloma charge #763

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 6, 2024

Fixes #762

This will lower coverage a bit, but at least we won't have a failing CI.

Checklist

  • Added a news entry

Developers certificate of origin

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (afdffb1) to head (6c71585).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   93.62%   91.76%   -1.87%     
==========================================
  Files         133      133              
  Lines        9747     9747              
==========================================
- Hits         9126     8944     -182     
- Misses        621      803     +182     
Flag Coverage Δ
fast-tests 91.76% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardjgowers richardjgowers merged commit 56816d3 into main Mar 7, 2024
10 checks passed
@richardjgowers richardjgowers deleted the no_espaloma_tests branch March 7, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make espaloma_charge untested code
2 participants