Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint itnterval #773

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Checkpoint itnterval #773

merged 4 commits into from
Mar 20, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 20, 2024

Fixes #772

Checklist

  • Added a news entry

Developers certificate of origin

@IAlibay IAlibay added this to the 1.0.0 milestone Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (a52d6c3) to head (89d21c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   93.58%   91.76%   -1.82%     
==========================================
  Files         133      133              
  Lines        9768     9768              
==========================================
- Hits         9141     8964     -177     
- Misses        627      804     +177     
Flag Coverage Δ
fast-tests 91.76% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


**Fixed:**

* Checkpoint interval default value has been set to 250 ps instead of 1 ps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can fix this in the release process but we don't need changelog until we've released 1.0 proper

@richardjgowers richardjgowers merged commit 4943cbb into main Mar 20, 2024
9 of 10 checks passed
@richardjgowers richardjgowers deleted the checkpoint-itnterval branch March 20, 2024 13:07
@IAlibay IAlibay mentioned this pull request Mar 20, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default checkpoint interval is 250x more frequent than in v0.15
2 participants