Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try speeding up CI #892

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Try speeding up CI #892

wants to merge 9 commits into from

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 21, 2024

Checklist

  • Added a news entry

Developers certificate of origin

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (ecc8a50) to head (fec5ee1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   93.98%   91.27%   -2.71%     
==========================================
  Files         134      134              
  Lines        9790     9790              
==========================================
- Hits         9201     8936     -265     
- Misses        589      854     +265     
Flag Coverage Δ
fast-tests 91.27% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Jul 21, 2024

Experiment 1: enforcing cpu threads to 1 doesn't seem to have any effect, could even be detrimental.
Experiment 2: removing coverage on long tests shaves off ~ 1/3 of the time.

@IAlibay
Copy link
Member Author

IAlibay commented Jul 21, 2024

Ok current state gets us to ~ 50% less, which at least gets rid of more immediate worries about 5h long runners. Merge will still be a problem though :/

@ijpulidos
Copy link
Contributor

ijpulidos commented Oct 29, 2024

I don't know if you are using feflow's HTF, but it might be worth noting that an optimization was performed when creating the HTF object that reduces the time significantly in CI. OpenFreeEnergy/feflow@42f2a59

EDIT: I just realized this hasn't been released yet.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2024

I don't know if you are using feflow's HTF, but it might be worth noting that an optimization was performed when creating the HTF object that reduces the time significantly in CI. OpenFreeEnergy/feflow@42f2a59

EDIT: I just realized this hasn't been released yet.

We are not and won't be for a while because of dependency order issues. A lot of the cost in CI here is because of coverage though, so we can squash that out for free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants