Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖✨：create Serbian translation VISION w/ Latin script #568

Merged
merged 7 commits into from
Oct 22, 2023
Merged

📖✨：create Serbian translation VISION w/ Latin script #568

merged 7 commits into from
Oct 22, 2023

Conversation

DerekNonGeneric
Copy link
Member

Pull Request Purpose

This PR contains the following:

  • 🐞🔧 bugfixing (🐜/🦟/🐛/🦗/🐝 et al.)
  • 🆕🎏 implementation of new feature(s)
  • ♻️ refactoring(s)
  • 📄 documentation modification(s)
  • 🔮 other

Are tests included?

  • yes (bugfixes and features will not be merged without
    tests    )
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless
    necessary    )
  • no

Description

This change, once again, adds the Serbian translation of our VISION file, but
this time using the Latin script.

Fixes: #84

/cc @emmitrovic @smorimoto

@DerekNonGeneric
meta(contrib): create initial TRANSLATORS file
9b02fe6 
To store canonical names and email addresses of
those who have made translation contributions.

Signed-off-by: Derek Lewis <[email protected]>
@DerekNonGeneric
📖✨：create Serbian translation VISION w/ Latin script
6cb5709 
Fixes: #84

Signed-off-by: Derek Lewis <[email protected]>
@DerekNonGeneric DerekNonGeneric added i18n An issue or PR related to internationalization (i18n) content Related to creating / editing content inclusion markdown An issue or PR related to Markdown labels Oct 21, 2023
@DerekNonGeneric DerekNonGeneric requested a review from a team October 21, 2023 02:41
@DerekNonGeneric
Copy link
Member Author

i would personally feel pleased w/ at least one @OpenINF/wg-a-team approval (preferably an @emmitrovic stamp)

DerekNonGeneric
DerekNonGeneric commented Oct 21, 2023
View reviewed changes
VISION.sr_Latn.md Outdated Show resolved Hide resolved
@DerekNonGeneric
Update VISION.sr_Latn.md
920b8f3 
Signed-off-by: Derek Lewis <[email protected]>
@DerekNonGeneric DerekNonGeneric added the author-ready PRs that are considered ready by their author label Oct 21, 2023
DerekNonGeneric
DerekNonGeneric commented Oct 21, 2023
View reviewed changes
Copy link
Member Author

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way i made this pr means its branch is not synced w/ main

one sec, do not stamp anything yet

DerekNonGeneric
DerekNonGeneric commented Oct 21, 2023
View reviewed changes
Copy link
Member Author

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerekNonGeneric DerekNonGeneric marked this pull request as draft October 21, 2023 22:34
@DerekNonGeneric
Copy link
Member Author

i guess y'all will have to allow me to somehow un-break the CI first

Refs: https://twitter.com/DynamicWebPaige/status/1715757026956177513|
Refs: https://research.google/pubs/pub52465/

@DerekNonGeneric DerekNonGeneric added documentation Improvements or additions to documentation and removed author-ready PRs that are considered ready by their author labels Oct 21, 2023
emmitrovic
emmitrovic approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@emmitrovic emmitrovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerekNonGeneric DerekNonGeneric mentioned this pull request Oct 22, 2023
Closed
@DerekNonGeneric DerekNonGeneric marked this pull request as ready for review October 22, 2023 09:35
@DerekNonGeneric DerekNonGeneric added the author-ready PRs that are considered ready by their author label Oct 22, 2023
OpenINFbot
OpenINFbot approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@OpenINFbot OpenINFbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OpenINFbot OpenINFbot merged commit 114067f into main Oct 22, 2023
@OpenINFbot OpenINFbot deleted the feat/vision-trans-serbian-latn branch October 22, 2023 10:03
@DerekNonGeneric DerekNonGeneric removed the author-ready PRs that are considered ready by their author label Oct 22, 2023
DerekNonGeneric added a commit that referenced this pull request Oct 22, 2023
@DerekNonGeneric
📖✨：create Serbian translation VISION w/ Latin script
bc95762 
Fixes: #84
PR-URL: #568
Acked-by: Sora Morimoto <[email protected]>
Reviewed-by: Milena Mitrovic <[email protected]>
Reviewed-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OpenINFbot OpenINFbot OpenINFbot approved these changes

@emmitrovic emmitrovic emmitrovic approved these changes

Assignees

@DerekNonGeneric DerekNonGeneric

@emmitrovic emmitrovic

Labels
content Related to creating / editing content documentation Improvements or additions to documentation i18n An issue or PR related to internationalization (i18n) markdown An issue or PR related to Markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug: i18n] Serbian translation of VISION file doesn't specify script
3 participants
@DerekNonGeneric @emmitrovic @OpenINFbot