Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖✨：add Japanese translation of VISION & add reviewers to TRANSLATORS #569

Merged
merged 3 commits into from
Oct 22, 2023
Merged

📖✨：add Japanese translation of VISION & add reviewers to TRANSLATORS #569

merged 3 commits into from
Oct 22, 2023
+13 −0

Conversation

DerekNonGeneric
Copy link
Member

Pull Request Purpose

This PR contains the following:

  • 🐞🔧 bugfixing (🐜/🦟/🐛/🦗/🐝 et al.)
  • 🆕🎏 implementation of new feature(s)
  • ♻️ refactoring(s)
  • 📄 documentation modification(s)
  • 🔮 other

Are tests included?

  • yes (bugfixes and features will not be merged without
    tests    )
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless
    necessary    )
  • no

Description

This change adds the Japanese translation of our VISION file and adds
the two members who will be reviewing it to the TRANSLATORS file.

/cc @smorimoto @jorgebucaran @emmitrovic as folks w/ more experience

@DerekNonGeneric DerekNonGeneric added documentation Improvements or additions to documentation i18n An issue or PR related to internationalization (i18n) content Related to creating / editing content inclusion markdown An issue or PR related to Markdown labels Oct 21, 2023
@DerekNonGeneric DerekNonGeneric changed the title 📖✨：add Japanese translation of VSION & add reviews to TRANSLATORS 📖✨：add Japanese translation of VISION & add reviewers to TRANSLATORS Oct 21, 2023
@DerekNonGeneric DerekNonGeneric added the author-ready PRs that are considered ready by their author label Oct 21, 2023
@DerekNonGeneric DerekNonGeneric mentioned this pull request Oct 22, 2023
Closed
@DerekNonGeneric DerekNonGeneric added help wanted Extra attention is needed and removed author-ready PRs that are considered ready by their author labels Oct 22, 2023
OpenINFbot
OpenINFbot approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@OpenINFbot OpenINFbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OpenINFbot OpenINFbot added the author-ready PRs that are considered ready by their author label Oct 22, 2023
@DerekNonGeneric
Copy link
Member Author

can we get one more @OpenINF/wg-a-team approval?

@OpenINFbot OpenINFbot merged commit 61f932f into OpenINF:main Oct 22, 2023
3 checks passed
@DerekNonGeneric DerekNonGeneric deleted the feat/jp-visions branch October 22, 2023 17:52
@DerekNonGeneric DerekNonGeneric removed the help wanted Extra attention is needed label Oct 22, 2023
DerekNonGeneric added a commit to DerekNonGeneric/openinf-github-dotrepo that referenced this pull request Oct 22, 2023
@DerekNonGeneric
📖✨：add Japanese translation of VISION & add profient to TRANSLATORS
20643d6 
PR-URL: OpenINF#569
Acked-by: Jorge Bucaran <[email protected]>
Acked-by: Sora Morimoto <[email protected]>
Reviewed-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
DerekNonGeneric added a commit to DerekNonGeneric/openinf-github-dotrepo that referenced this pull request Oct 22, 2023
@DerekNonGeneric
📖✨：add Japanese translation of VISION & add members to TRANSLATORS
26ac704 
PR-URL: OpenINF#569
Acked-by: Jorge Bucaran <[email protected]>
Acked-by: Sora Morimoto <[email protected]>
Reviewed-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
DerekNonGeneric added a commit to DerekNonGeneric/openinf-github-dotrepo that referenced this pull request Oct 22, 2023
@DerekNonGeneric
📖✨：add Japanese translation of VISION & add members to TRANSLATORS
ea4cdb0 
PR-URL: OpenINF#569
Acked-by: Jorge Bucaran <[email protected]>
Acked-by: Sora Morimoto <[email protected]>
Reviewed-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
DerekNonGeneric added a commit to DerekNonGeneric/openinf-github-dotrepo that referenced this pull request Oct 22, 2023
@DerekNonGeneric
📖✨：add Japanese translation of VISION & add members to TRANSLATORS
a4438ed 
PR-URL: OpenINF#569
Acked-by: Jorge Bucaran <[email protected]>
Acked-by: Sora Morimoto <[email protected]>
Reviewed-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
@DerekNonGeneric DerekNonGeneric removed the author-ready PRs that are considered ready by their author label Oct 22, 2023
DerekNonGeneric added a commit that referenced this pull request Oct 22, 2023
@DerekNonGeneric
📖✨：add Japanese translation of VISION & add members to TRANSLATORS
a7c7a98 
PR-URL: #569
Acked-by: Jorge Bucaran <[email protected]>
Acked-by: Sora Morimoto <[email protected]>
Reviewed-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OpenINFbot OpenINFbot OpenINFbot approved these changes

@jorgebucaran jorgebucaran Awaiting requested review from jorgebucaran

@emmitrovic emmitrovic Awaiting requested review from emmitrovic

@smorimoto smorimoto Awaiting requested review from smorimoto

Assignees

@jorgebucaran jorgebucaran

@smorimoto smorimoto

Labels
content Related to creating / editing content documentation Improvements or additions to documentation i18n An issue or PR related to internationalization (i18n) markdown An issue or PR related to Markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DerekNonGeneric @OpenINFbot @jorgebucaran @smorimoto