Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue 2 of #3919
Issue 1 must still be fixed.
I think a good solution would be to add 2 new checks for checkSelfCondition:
_homunculus_noinfo_dead: is only positive when $char->{homunculus_info}{dead} is undefined
_homunculus_noinfo_resting: is only positive when $char->{homunculus_info}{vaporized} is undefined
So we could make some useSelfSkills cleverly to fix the issue like:
useSelf_skill Resurrect Homunculus {
homunculus 0
homunculus_noinfo_dead 1
}
If it works, great, homun is alive, if it fails we now know $char->{homunculus_info}{dead} is 0. Then we can use:
useSelf_skill Call Homunculus {
homunculus 0
homunculus_noinfo_resting 1
}
If it works, great, homun is alive, if it fails we now know $char->{homunculus_info}{vaporized} is 0.