Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homunculus state crashes #3920

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Fix homunculus state crashes #3920

merged 3 commits into from
Dec 26, 2024

Conversation

Henrybk
Copy link
Contributor

@Henrybk Henrybk commented Dec 26, 2024

This fixes issue 2 of #3919

Issue 1 must still be fixed.

I think a good solution would be to add 2 new checks for checkSelfCondition:
_homunculus_noinfo_dead: is only positive when $char->{homunculus_info}{dead} is undefined
_homunculus_noinfo_resting: is only positive when $char->{homunculus_info}{vaporized} is undefined

So we could make some useSelfSkills cleverly to fix the issue like:
useSelf_skill Resurrect Homunculus {
homunculus 0
homunculus_noinfo_dead 1
}

If it works, great, homun is alive, if it fails we now know $char->{homunculus_info}{dead} is 0. Then we can use:

useSelf_skill Call Homunculus {
homunculus 0
homunculus_noinfo_resting 1
}

If it works, great, homun is alive, if it fails we now know $char->{homunculus_info}{vaporized} is 0.

@Henrybk Henrybk merged commit bc74f0f into master Dec 26, 2024
9 checks passed
@Henrybk Henrybk deleted the Fix_homun_state branch December 26, 2024 15:16
@ya4ept
Copy link
Contributor

ya4ept commented Dec 26, 2024

@Henrybk please add a description on this page:
https://openkore.com/wiki/homunculus_noinfo_dead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants