Update timeout

[subCode321]

Fixes #162

Earlier, the GUI tests were failing because of a timeout issue. I believe this should fix that.

Summary by CodeRabbit

• Tests
  • Enhanced testing routines by implementing a maximum wait time of 10 seconds for specific operations. This adjustment ensures that tests terminate promptly if responses are delayed, leading to a more efficient and reliable testing experience. All other testing behaviors remain unchanged.

[coderabbitai]

Walkthrough

The change updates the test_view_raw_ms_data function in the test suite by modifying the invocation of the launch.run() method. The call is now made with a timeout parameter (timeout=10), which limits the duration of the run operation. The rest of the function, including the logic for loading example files and selecting a spectrum, remains unchanged, preserving the overall control flow and behavior aside from the timeout specification.

Changes

File(s)	Change Summary
test_gui.py	Modified the test_view_raw_ms_data function to call launch.run(timeout=10) instead of launch.run().

Sequence Diagram(s)

sequenceDiagram
    participant Test as test_view_raw_ms_data
    participant Launch as launch module

    Test->>Launch: run(timeout=10)
    Launch-->>Test: returns response (or timeout)

Loading

Poem

In the world of tests I bound,
With timeout added, I’ve found
A quicker step, a timely dash,
Through code paths I softly mash.
Hoppy changes, code so bright,
A rabbit’s leap into the night!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

test_gui.py (1)

69-69: Timeout addition looks good.

Adding the timeout parameter addresses the failing GUI tests issue mentioned in PR #162, and 10 seconds seems reasonable for viewing raw MS data.

For consistency, consider reviewing other launch.run() calls in the file (lines 36, 49, 56, 77, 97, 103) that don't specify timeouts. Adding appropriate timeouts to all run calls would prevent tests from hanging indefinitely.

Also, consider extracting timeout values to constants at the top of the file (like STANDARD_TIMEOUT = 10 and WORKFLOW_TIMEOUT = 60) for easier maintenance.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75fa783 and 15e5a13.

📒 Files selected for processing (1)

• test_gui.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: build-full-app
• GitHub Check: build-simple-app
• GitHub Check: build-openms

[t0mdavid-m]

Thank you for your contribution! LGTM